ci: consolidate structural PR checks into one gate#4540
Open
ryjones wants to merge 1 commit into
Open
Conversation
5dc02cf to
f394976
Compare
Contributor
|
I think each package individual check leafs are useful and should remain as is; however, we could aggregate structural ones (DCO, PR title, PR body checks, etc) into one |
f394976 to
afc0183
Compare
Contributor
Author
|
@RafaelAPB If this is how you intended I can mark ready for review whenever |
afc0183 to
06ed095
Compare
sandeepnRES
approved these changes
Jul 6, 2026
9c09bfe to
fad175b
Compare
fad175b to
5713b90
Compare
Aggregate the structural, PR-metadata checks into a single required status
context so branch protection can require one rollup instead of each check
individually. The per-package CI check leaves are intentionally left as
individual contexts (useful signal) and are not touched here.
Consolidate the two structural PR-lint workflows into one
`pr-structural-checks.yaml` ("PR Structural Checks") holding all four jobs:
- Commit Lint
- Validate PR title
- Validate PR title match with latest commit message
- Validate PR Type
plus a `PR Structural Checks Success` rollup that `needs` all of them. It
uses `if: always()` and fails only when a dependency result is `failure` or
`cancelled`, so a skipped job is treated as passing. This replaces the
former `commitlint-pull-request.yaml` and `semantic-pull-request.yaml`.
External app checks (DCO, dpulls, mergefreeze) emit their own status
contexts and cannot be pulled into a workflow `needs` graph, so they stay
standalone.
Follow-up (manual, after merge): require `PR Structural Checks Success` in
place of the individual Commit Lint / Validate PR * contexts.
Assisted-by: anthropic:claude-opus-4-8 actionlint
Signed-off-by: Ry Jones <ry@linux.com>
5713b90 to
2381f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregate the structural, PR-metadata checks into a single required status context so branch protection can require one rollup instead of each check individually. The per-package CI check leaves are intentionally left as individual contexts (useful signal) and are not touched here.
Consolidate the two structural PR-lint workflows into one
pr-structural-checks.yaml("PR Structural Checks") holding all four jobs:plus a
PR Structural Checks Successrollup thatneedsall of them. It usesif: always()and fails only when a dependency result isfailureorcancelled, so a skipped job is treated as passing. This replaces the formercommitlint-pull-request.yamlandsemantic-pull-request.yaml.External app checks (DCO, dpulls, mergefreeze) emit their own status contexts and cannot be pulled into a workflow
needsgraph, so they stay standalone.Follow-up (manual, after merge): require
PR Structural Checks Successin place of the individual Commit Lint / Validate PR * contexts.Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficiently and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when, and why.Signed-off-by: Name <email>) to certify the Developer Certificate of Origin (DCO). Use the-sflag withgit commit. See signing commits for more information. AI agents must not add Signed-off-by tags — only the human submitter may certify the DCO (see AI Guidelines §7).Assisted-bytag in the commit message per the AI Guidelines §2.2 (e.g.,Assisted-by: GitHub-Copilot:claude-opus-4). All AI-generated code must be human-reviewed before submission.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.