Ci/fix fabric tests#4560
Closed
ryjones wants to merge 2 commits into
Closed
Conversation
Aggregate the structural, PR-metadata checks into a single required status
context so branch protection can require one rollup instead of each check
individually. The per-package CI check leaves are intentionally left as
individual contexts (useful signal) and are not touched here.
Consolidate the two structural PR-lint workflows into one
`pr-structural-checks.yaml` ("PR Structural Checks") holding all four jobs:
- Commit Lint
- Validate PR title
- Validate PR title match with latest commit message
- Validate PR Type
plus a `PR Structural Checks Success` rollup that `needs` all of them. It
uses `if: always()` and fails only when a dependency result is `failure` or
`cancelled`, so a skipped job is treated as passing. This replaces the
former `commitlint-pull-request.yaml` and `semantic-pull-request.yaml`.
External app checks (DCO, dpulls, mergefreeze) emit their own status
contexts and cannot be pulled into a workflow `needs` graph, so they stay
standalone.
Follow-up (manual, after merge): require `PR Structural Checks Success` in
place of the individual Commit Lint / Validate PR * contexts.
Assisted-by: anthropic:claude-opus-4-8 actionlint
Signed-off-by: Ry Jones <ry@linux.com>
The docker-pull warm-up steps pulled cactus-fabric2-all-in-one:v3.0.0-beta.1, a tag no test references, so the multi-GB pull of the tag the tests do boot (v2.1.0 via FABRIC_25_LTS_AIO_IMAGE_VERSION) happened inside the timed jest run of every affected job. Point all pre-pulls at v2.1.0 instead. Affected workflows: connector-packages, examples, other-packages, satp-hermes. Also fix DEFAULT_FABRIC_2_AIO_IMAGE_VERSION in cactus-test-tooling: it was pinned to 2023-08-17-issue2057-pr2135, which exists only under the retired ghcr.io/hyperledger org, not under ghcr.io/hyperledger-cacti where DEFAULT_FABRIC_2_AIO_IMAGE_NAME points, so its only consumer (add-orgs.test.ts) failed at image pull. Bump it to v2.1.0 and the paired DEFAULT_FABRIC_2_AIO_FABRIC_VERSION to 2.5.6, matching the Fabric version baked into that image at build time (the peer/orderer images are frozen in via the FABRIC_VERSION build ARG, so image tag and runtime FABRIC_VERSION must agree). Assisted-by: anthropic:claude-fable-5 Signed-off-by: Ry Jones <ry@linux.com>
ryjones
requested review from
AndreAugusto11,
LordKubaya,
RafaelAPB,
VRamakrishna,
outSH and
sandeepnRES
as code owners
sandeepnRES
reviewed
Jul 7, 2026
| "ghcr.io/hyperledger-cacti/cactus-fabric2-all-in-one"; | ||
| export const DEFAULT_FABRIC_2_AIO_IMAGE_VERSION = "2023-08-17-issue2057-pr2135"; | ||
| export const DEFAULT_FABRIC_2_AIO_FABRIC_VERSION = "2.4.4"; | ||
| export const DEFAULT_FABRIC_2_AIO_IMAGE_VERSION = "v2.1.0"; |
Contributor
There was a problem hiding this comment.
Can we use v3.0.0-beta.1 here instead?
sandeepnRES
reviewed
Jul 7, 2026
| export const DEFAULT_FABRIC_2_AIO_IMAGE_VERSION = "v2.1.0"; | ||
| export const DEFAULT_FABRIC_2_AIO_FABRIC_VERSION = "2.5.6"; | ||
|
|
||
| export const FABRIC_25_LTS_AIO_IMAGE_VERSION = "v2.1.0"; |
Contributor
There was a problem hiding this comment.
Please check if this also needs to be updated if considering updating to v3.0.0-beta.1 for everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
Assisted-bytag in the commit message per the AI Guidelines §2.2 (e.g.,Assisted-by: GitHub-Copilot:claude-opus-4). All AI-generated code must be human-reviewed before submission.