Skip to content

feat: add VDR capabilities to the cloud-agent using the prism-node#1685

Merged
yshyn-iohk merged 3 commits intomainfrom
feat/vdr-key
Feb 18, 2026
Merged

feat: add VDR capabilities to the cloud-agent using the prism-node#1685
yshyn-iohk merged 3 commits intomainfrom
feat/vdr-key

Conversation

@yshyn-iohk
Copy link
Copy Markdown
Contributor

@yshyn-iohk yshyn-iohk commented Dec 10, 2025 •
edited
Loading

Description

  • add new VDR key type handling (API, signer, validation, SQL)
  • update prism-node and VDR endpoints, Kotlin client, configs, and scripts
  • stabilize VDR e2e: split neoprism/prism-node jobs, enable memory/db drivers, pin testcontainers and docker API 1.44, parameterize prism-node image

Checklist

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk requested a review from a team as a code owner December 10, 2025 07:20
@yshyn-iohk yshyn-iohk marked this pull request as draft December 10, 2025 07:21
@yshyn-iohk yshyn-iohk changed the title WIP: add VDR capabilities to the cloud-agent using the prism-node feat: add VDR capabilities to the cloud-agent using the prism-node Dec 10, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 10, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
9 Security Hotspots

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2025 •
edited
Loading

Integration Test Results

 23 files   23 suites   3s ⏱️
 58 tests  58 ✅ 0 💤 0 ❌
106 runs  106 ✅ 0 💤 0 ❌

Results for commit 48850d0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2025 •
edited
Loading

Unit Test Results

109 files  + 3  109 suites  +3   18m 53s ⏱️ + 16m 4s
912 tests +67  904 ✅ +370  8 💤 ±0  0 ❌  - 303 
919 runs  +43  911 ✅ +374  8 💤 ±0  0 ❌  - 331 

Results for commit 48850d0. ± Comparison against base commit 676e47b.

This pull request removes 17 and adds 84 tests. Note that renamed tests count towards both. 
org.hyperledger.identus.iam.authentication.apikey.ApiKeyAuthenticatorSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.iam.authentication.apikey.JdbcAuthenticationRepositorySpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.iam.authorization.keycloak.admin.KeycloakAdminSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.iam.authorization.keycloak.admin.KeycloakPermissionManagementServiceSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.issue.controller.IssueControllerImplSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.pollux.credentialdefinition.CredentialDefinitionBasicSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.pollux.credentialdefinition.CredentialDefinitionFailureSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.pollux.credentialdefinition.CredentialDefinitionLookupAndPaginationSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
org.hyperledger.identus.pollux.schema.CredentialSchemaAnoncredSpec ‑ (It is not a test it is a sbt.testing.SuiteSelector)
…

org.hyperledger.identus.agent.vdr.VdrServiceImplSpec ‑ VdrServiceImpl routing - create uses prism-node when drid=prism-node
org.hyperledger.identus.agent.vdr.VdrServiceImplSpec ‑ VdrServiceImpl routing - routes proxy URLs to proxy driver
org.hyperledger.identus.agent.vdr.VdrServiceImplSpec ‑ VdrServiceImpl routing - routes raw URLs to prism-node service when present
org.hyperledger.identus.agent.walletapi.service.ValidateInternalKeyRemovalSpec ‑ validateInternalKeyRemoval - fails when key does not exist
org.hyperledger.identus.agent.walletapi.service.ValidateInternalKeyRemovalSpec ‑ validateInternalKeyRemoval - fails when key is not internal HD (rand/public)
org.hyperledger.identus.agent.walletapi.service.ValidateInternalKeyRemovalSpec ‑ validateInternalKeyRemoval - fails when key usage is not VDR
org.hyperledger.identus.agent.walletapi.service.ValidateInternalKeyRemovalSpec ‑ validateInternalKeyRemoval - succeeds when key is VDR internal
org.hyperledger.identus.agent.walletapi.util.ManagedDIDTemplateValidatorSpec ‑ ManagedDIDTemplateValidator - accept DID template with optional VDR signing internal key
org.hyperledger.identus.agent.walletapi.util.ManagedDIDTemplateValidatorSpec ‑ ManagedDIDTemplateValidator - reject DID template when internal key purpose is unsupported
org.hyperledger.identus.agent.walletapi.util.ManagedDIDTemplateValidatorSpec ‑ ManagedDIDTemplateValidator - reject DID template when key ids are duplicated across public and internal keys
…

♻️ This comment has been updated with latest results.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 10, 2025

Coverage Status

coverage: 47.655% (-0.007%) from 47.662%
when pulling dab7ede on feat/vdr-key
into 6d6a65e on main.

mineme0110
mineme0110 reviewed Dec 10, 2025
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
@yshyn-iohk yshyn-iohk force-pushed the feat/vdr-key branch 4 times, most recently from 2a6b092 to 0b2a0f9 Compare February 17, 2026 18:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 17, 2026 •
edited
Loading

Integration Test Results (prism-node)

1 tests   1 ✅  2s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 48850d0.

♻️ This comment has been updated with latest results.

@yshyn-iohk
feat: support new VDR key type and stabilize VDR e2e (#1596)
12ef628 
- add new VDR key type handling (API, signer, validation, SQL)
- update prism-node and VDR endpoints, kotlin client, configs and scripts
- stabilize VDR e2e: split neoprism/prism-node jobs, enable memory/db drivers, pin testcontainers and docker API 1.44, parameterize prism-node image

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk yshyn-iohk marked this pull request as ready for review February 18, 2026 03:58
@yshyn-iohk
feat: tighten VDR key validation and harden e2e compose
82fee28 
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
patextreme
patextreme approved these changes Feb 18, 2026
View reviewed changes
Comment thread cloud-agent/service/server/src/main/resources/application.conf
@yshyn-iohk
Revert "feat: tighten VDR key validation and harden e2e compose"
48850d0 
This reverts commit 82fee28.

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 18, 2026

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

@yshyn-iohk yshyn-iohk merged commit 9931f22 into main Feb 18, 2026
16 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/vdr-key branch February 18, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mineme0110 mineme0110 mineme0110 left review comments

@patextreme patextreme patextreme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yshyn-iohk @coveralls @patextreme @mineme0110