Set UID and GID for github generated docker images

[cmickeyb]

Explicitly set the user and group ids for images that will be pushed ghcr by the docker workflow. This makes it easier to manage permissions of the xfer directory when using images from the registry.

[g2flyer]

hmm, isn't just changing group (chgrp -R pdo_group $PDO_SOURCE_ROOT/docker/xfer) the only thing you need (and if you are in that group wouldn't need sudo)?

But you also would have to make sure it is group writeable Unfortunately it doesn't seem there is an easy way to define a specific umask for both build and run. Probably easiest just do chmod -R g+w at end? Or could pre-set sticky bits on the directory come to the rescue? as long as we do not create new directories during build (as currently), not having group-write on the created files is actually at least as far as make clean goes. The only case i could somewhat see as problematic is if user has umask 077 and you want to read files? But then i guess nowadays this umask is not very common and probably the scenario neither ...

Also the actual user running should be in that new group? (i.e., you might also want to add the convenience comments on the sudo groupadd pdo_group and sudo usermod $(USER) -a -G pdo_group?)

Also, why not even add a make command to do these changes? And i guess there should ideally also be a docu-update?

[g2flyer]

FYI: could get it working as follows:

# - setup once
sudo groupadd pdo_
sudo usermod $(USER) -a -G pdo_group
# create new login shell to acquire new group
chgrp -Rvb pdo_group $PDO_SOURCE_ROOT/docker/xfer

# - test which then worked ..
make -C docker PDO_USER_UID=55172 PDO_GROUP_UID=55172 clean
make -C docker PDO_USER_UID=55172 PDO_GROUP_UID=55172
make -C docker PDO_USER_UID=55172 PDO_GROUP_UID=55172 test_no_reset
make -C docker PDO_USER_UID=55172 PDO_GROUP_UID=55172 clean

# - FYI docker build warnings i got ..
 X warnings found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG pdo_services_base:${PDO_VERSION} results in empty or invalid base image name (line 23)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 31)