Add .gitattributes to configure Linguist for Protocol Buffer files#278
Conversation
jt-nti
left a comment
There was a problem hiding this comment.
I think that this PR is related to https://github.com/github-linguist/linguist/blob/main/docs/overrides.md but I'm not sure why it's necessary. As far as I know, there aren't any *.protobuf files, and the following search seems to find the files I would expect...
Please could you explain what the new .gitattributes file is intended to achieve? If there is a good reason, I think it needs updating to match the files/directories found in this repository, and you would need a DCO sign off on your commit.
Thanks.
|
Hey @jt-nti, The reason is I don't think the.proto files will show up in the repository because the linguist is not able to understand it. I use this exact same https://github.com/hyperledger/fabric-protos/blob/main/gateway%2Fgateway.proto I know it's a small PR but it's just better visibility for people who are looking at protobuf for the first time. Thanks. |
Signed-off-by: oh-tarnished <srikanthkandarp@gmail.com>
|
Signed - DCO |
|
Ah, I see, you want Protocol Buffer to show up in the repository stats...
In that case, I think you only need this... https://github.com/hyperledger/fabric-protos/pull/280/changes I'd be happy to approve your PR if you remove the other changes. Thanks for adding the DCO signoff. |
4501875 to
4150f1e
Compare
Signed-off-by: oh-tarnished <srikanthkandarp@gmail.com>
Signed-off-by: oh-tarnished <srikanthkandarp@gmail.com>
|
Done - removed the other configuration |
jt-nti
left a comment
There was a problem hiding this comment.
Thanks @oh-tarnished
Are you happy to merge this @pfi79?
|
Nice, thanks @oh-tarnished!
|


adding .gitattributes