test: unikraft and app-elfloader bump#104
Open
danbugs wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Kraft example configurations to use newer Unikraft and app-elfloader revisions intended to support Hyperlight (notably around vfork/execve-related behavior).
Changes:
- Swaps Unikraft source/version in multiple
examples/*/kraft.yamlfiles fromunikraft/unikraft@plat-hyperlighttodanbugs/unikraft@feat/vfork-stack-save. - Swaps
app-elfloadersource/version fromunikraft/app-elfloader@plat-hyperlighttodanbugs/app-elfloader@fix/vfork-execve.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/shell/kraft.yaml | Updates Unikraft + app-elfloader refs for the shell example. |
| examples/rust/kraft.yaml | Updates Unikraft + app-elfloader refs for the Rust example. |
| examples/python/kraft.yaml | Updates Unikraft + app-elfloader refs for the Python example. |
| examples/python-tools/kraft.yaml | Updates Unikraft + app-elfloader refs for the Python tools example. |
| examples/python-agent/kraft.yaml | Updates Unikraft + app-elfloader refs for the Python agent example. |
| examples/python-agent-driver/kraft.yaml | Updates Unikraft + app-elfloader refs for the Python agent driver example. |
| examples/powershell/kraft.yaml | Updates Unikraft + app-elfloader refs for the PowerShell example. |
| examples/nodejs/kraft.yaml | Updates Unikraft + app-elfloader refs for the Node.js example. |
| examples/networking-py/kraft.yaml | Updates Unikraft + app-elfloader refs for the Python networking example. |
| examples/multifn-c/kraft.yaml | Updates Unikraft + app-elfloader refs for the multi-function C example. |
| examples/hostfs-posix-py/kraft.yaml | Updates Unikraft + app-elfloader refs for the hostfs POSIX Python example. |
| examples/hostfs-posix-c/kraft.yaml | Updates Unikraft + app-elfloader refs for the hostfs POSIX C example. |
| examples/helloworld-c/kraft.yaml | Updates Unikraft + app-elfloader refs for the hello world C example. |
| examples/go/kraft.yaml | Updates Unikraft + app-elfloader refs for the Go example. |
| examples/go-http/kraft.yaml | Updates Unikraft + app-elfloader refs for the Go HTTP example. |
| examples/dotnet/kraft.yaml | Updates Unikraft + app-elfloader refs for the .NET example. |
| examples/dotnet-nativeaot/kraft.yaml | Updates Unikraft + app-elfloader refs for the .NET NativeAOT example. |
| examples/dotnet-http/kraft.yaml | Updates Unikraft + app-elfloader refs for the .NET HTTP example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danbugs
force-pushed
the
test/unikraft-elfloader-bump
branch
from
b7e6b8e to
f89e9ef
Compare
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
force-pushed
the
test/unikraft-elfloader-bump
branch
from
383a00e to
a7daad8
Compare
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
force-pushed
the
test/unikraft-elfloader-bump
branch
from
19d79f7 to
7f1bc77
Compare
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
force-pushed
the
test/unikraft-elfloader-bump
branch
from
7f1bc77 to
642f609
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 642f609 | Previous: 682ad20 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
120 ms |
0.92 |
density (per VM) |
8 MB |
8 MB |
1 |
snapshot (disk) |
653 MiB |
653 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 642f609 | Previous: 682ad20 | Ratio |
|---|---|---|---|
hello_world (median) |
293 ms |
291 ms |
1.01 |
pandas (median) |
927 ms |
1024 ms |
0.91 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
661 MiB |
661 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
…le crash Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
…tore Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.