feat(clippy): add disallowed macros for asserts in clippy.toml #1376
Open
simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
Open
feat(clippy): add disallowed macros for asserts in clippy.toml #1376simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
simongdavies wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
…ppress globally Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
dblnz
approved these changes
Apr 15, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
I see the changes only affect hyperlight-common, shouldn't we do the same thing for the other crates used on the host?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces stricter linting for assertion macros in release builds.
Linting and Build Configuration Changes:
clippy.tomlconfiguration disallowing the use ofassert!,assert_eq!, andassert_ne!macros in release builds, with explanations for each.lib.rsto globally suppress theclippy::disallowed_macroslint, then selectively re-enable it for release host builds (withstdfeature), while allowing asserts for guest targets and in test/debug builds. This is thoroughly documented in comments.