fix: resolve signals declared in JSX template-literal data-signals - #1
Merged
Conversation
Owner
|
sorry, missed your pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves signals declared via a JSX template-literal
data-signals(e.g.data-signals={`{ status: 'idle', lapCount: 0 }`}), which were previously reported as undefined for every usage.Two fixes:
ts_util::extract_attrnow unwraps a surrounding template literal in thejsx_expressionarm so the value is the object body rather than a backtick-quoted string (the leading backtick was defeating the{-prefixed object-literal check insignal_names_from_attr).find_obj_key_rangesnow anchors onvalue.find('{')instead ofvalue.len() - trimmed.len()so go-to-definition/rename ranges stay byte-accurate when the body has surrounding whitespace.