feat: add imagePullSecrets support for operator and managed resources#395
Open
Richie1710 wants to merge 2 commits intohyperspike:mainfrom
Open
feat: add imagePullSecrets support for operator and managed resources#395Richie1710 wants to merge 2 commits intohyperspike:mainfrom
Richie1710 wants to merge 2 commits intohyperspike:mainfrom
Conversation
Allow users to specify imagePullSecrets in the Valkey CRD spec to enable pulling container images from private registries. The secrets are propagated to both the StatefulSet and the external access proxy Deployment pod specs.
Add post-processing step to helm-gen that injects a conditional imagePullSecrets block into the operator deployment template. Users can set controllerManager.imagePullSecrets in their Helm values to pull the operator image from private registries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
imagePullSecretsto enable pulling container images from private registries. This feature works on two levels:imagePullSecretsin the Helm chart values to pull the operator image itself from a private registryimagePullSecretsin the Valkey CRD spec to pull Valkey server and proxy images from private registriesChanges
CRD Changes
imagePullSecrets []corev1.LocalObjectReferencefield toValkeySpecAPI typeimagePullSecretschangeHelm Chart Changes
make helm-genthat injects conditionalimagePullSecretstemplate into the operator deploymentcontrollerManager.imagePullSecretsin Helm values