Skip to content

Language button position#2000

Open
webguru-hypha wants to merge 2 commits intomainfrom
cursor/language-button-position-2f7b
Open

Language button position#2000
webguru-hypha wants to merge 2 commits intomainfrom
cursor/language-button-position-2f7b

Conversation

@webguru-hypha
Copy link
Contributor

@webguru-hypha webguru-hypha commented Mar 12, 2026

Move the language select button left to the profile icon by swapping their order in the layout.

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Refactor
    • Navigation entries are now rendered as separate navigation buttons in the top menu instead of inside the profile menu.
    • Profile menu retains profile, notifications, theme toggle and logout options; navigation links have been moved out of the profile dropdown.
    • Language selector is preserved and now appears before the profile control in the header for easier access.

@cursor
Copy link

cursor bot commented Mar 12, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7a5c4215-c55c-474a-b3fc-779e52d53fcb

📥 Commits

Reviewing files that changed from the base of the PR and between 5dff975 and 2545cd0.

📒 Files selected for processing (3)
  • apps/web/src/app/layout.tsx
  • packages/epics/src/people/components/button-profile.connected.tsx
  • packages/epics/src/people/components/button-profile.tsx
💤 Files with no reviewable changes (1)
  • packages/epics/src/people/components/button-profile.connected.tsx

📝 Walkthrough

Walkthrough

Removed the navItems prop from ButtonProfile and its connected wrapper; navigation items are now supplied as explicit ButtonNavItem children in the top-level layout. MenuTop now imports/renders ButtonNavItem entries and conditionally places ConnectedLanguageSelect before the profile.

Changes

Cohort / File(s) Summary
Profile Button Components
packages/epics/src/people/components/button-profile.tsx, packages/epics/src/people/components/button-profile.connected.tsx
Removed navItems prop and ButtonNavItemProps import; updated prop types/signatures and removed all rendering that consumed a navItems array.
Layout / Top Menu
apps/web/src/app/layout.tsx
Imported ButtonNavItem; added explicit <ButtonNavItem> children for network and my-spaces inside MenuTop; conditionally render ConnectedLanguageSelect before the profile and stopped passing navItems into ConnectedButtonProfile.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • DSanich
  • evgenibir

Poem

🐰
I hopped through code and nudged a line,
Nav items scattered, now they shine.
Language hops left, profile stands near,
Buttons in order, the menu is clear.
A tiny leap for cleaner UI cheer.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Language button position' directly aligns with the PR objective to move the language select button by swapping its order with the profile icon in the layout.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/language-button-position-2f7b
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@webguru-hypha webguru-hypha marked this pull request as ready for review March 12, 2026 15:52
@webguru-hypha webguru-hypha force-pushed the cursor/language-button-position-2f7b branch from f08833a to 5dff975 Compare March 16, 2026 16:39
@cursor
Copy link

cursor bot commented Mar 16, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursoragent and others added 2 commits March 17, 2026 12:51
Co-authored-by: webguru-hypha <webguru-hypha@users.noreply.github.com>
Navigation items (Network, My Spaces) are now rendered as direct
children of MenuTop in the layout, decoupling them from ButtonProfile.

Made-with: Cursor
@plitzenberger plitzenberger force-pushed the cursor/language-button-position-2f7b branch from 5dff975 to 2545cd0 Compare March 17, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants