Skip to content

Agreements settings translation#2001

Merged
plitzenberger merged 87 commits intomainfrom
cursor/agreements-settings-translation-d52e
Mar 24, 2026
Merged

Agreements settings translation#2001
plitzenberger merged 87 commits intomainfrom
cursor/agreements-settings-translation-d52e

Conversation

@webguru-hypha
Copy link
Copy Markdown
Contributor

@webguru-hypha webguru-hypha commented Mar 12, 2026

QA Checklist (Manual)

Scope

Validate the select-settings-action and select-create-action i18n/refactor changes, plus shared governance/components touched by this PR.

Test Matrix

  • Locales: en, de, fr, es, pt
  • Roles/states: signed-out user, signed-in non-member, signed-in member
  • Browsers: Chromium + one secondary browser
  • Viewports: desktop + mobile width

Core Navigation Paths

  • /{lang}/dho/{spaceId}/[tab]/select-settings-action
  • /{lang}/dho/{spaceId}/agreements/create
  • /{lang}/dho/{spaceId}/agreements/create/activate-spaces
  • /{lang}/dho/{spaceId}/agreements/create/buy-hypha-tokens
  • /{lang}/dho/{spaceId}/agreements/create/space-to-space-membership
  • /{lang}/dho/{spaceId}/[tab]/space-configuration
  • /{lang}/dho/{spaceId}/agreements/proposal/{documentSlug}
  • /{lang}/dho/{spaceId}/agreements/proposal/{documentSlug}/voters
  • /{lang}/profile/{personSlug}/edit
  • /{lang}/my-spaces and /{lang}/network

Functional Checks

  • Every visible label/button/help text is localized (no fallback English leaks in non-EN locales)
  • Form validation messages render localized copy (including dynamic/interpolated errors)
  • Rich-text/i18n CTA sentences read naturally in each locale (no broken word-order from concatenated fragments)
  • Proposal labels and metadata display correctly across states (open/accepted/rejected)
  • Date/number/currency formatting follows locale conventions
  • Search placeholders and attachment/link labels are localized in shared components

Regression Checks (Refactor-sensitive)

  • Create agreement flow submits expected payloads and routes correctly
  • Activate spaces / buy tokens insufficient-funds messaging + CTA behavior works
  • Issue-new-token validation and file-format error parsing still works with localized output
  • Notification centre labels/wrappers render correctly; missing keys gracefully fallback where intended
  • Treasury/proposal token type labels remain localized consistently across cards/details/forms

Error & Boundary Coverage

  • Validate route-level error pages for agreements/members/overview/treasury tabs
  • Validate global error and not-found pages are localized
  • Confirm proposal/voters side panel back/close actions are translated and function correctly

API/Runtime Safety

  • POST /api/webhooks/proposal/created does not crash app when signing key is missing
  • POST /api/webhooks/proposal/executed does not crash app when signing key is missing
  • POST /api/webhooks/proposal/rejected does not crash app when signing key is missing
  • POST /api/webhooks/space/created does not crash app when signing key is missing

Acceptance Criteria

  • No untranslated/incorrect strings in supported locales on tested paths
  • No runtime errors in console for tested flows
  • No navigation regressions in create/settings/proposal flows
  • Build-critical flows pass smoke checks on preview

Summary by CodeRabbit

  • New Features

    • Added Portuguese and Spanish locales with comprehensive translations.
  • Improvements

    • App-wide UI localization: labels, buttons, placeholders, validation and error messages.
    • Locale-aware date/time formatting and translated loader/backdrop messages.
    • More configurable UI text (search placeholders, attachment label, keep-window-open message).
  • Bug Fixes

    • Webhook endpoints respond with clear error when signing keys are not configured.
    • Updated Smart Contract integration link.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants