Skip to content

deprecate title_or_node_id #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoahHarel wants to merge 6 commits into
base: main
Choose a base branch
from
Open

deprecate title_or_node_id #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9eace24
deprecate title_or_node_id
Dec 17, 2023
3145cd0
add deprecated to setup
Dec 17, 2023
1e3488d
stop updating pip
Dec 17, 2023
652ee11
immutables version
Dec 17, 2023
068f583
check if can be built
Dec 19, 2023
05956c9
re-add deprecation
Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
7 changes: 5 additions & 2 deletions knowledge_graph/querying.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import functools
from typing import Callable, Dict, FrozenSet, Iterable, Optional, Tuple

import deprecated
import gamla

from . import (
Expand Down Expand Up @@ -195,9 +196,11 @@ def find_exactly(text: str):
)


title_or_node_id = gamla.first(
get_node_title, storage.node_id, exception_type=NodeTitleMissing
@deprecated.deprecated(
reason="ID can be anything, which makes this function unexpected. Use `get_node_title` or 'node_id' instead."
)
def title_or_node_id(node: storage.Node) -> str:
return gamla.first(get_node_title, storage.node_id, exception_type=NodeTitleMissing)(node)


@gamla.curry
Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
packages=setuptools.find_namespace_packages(),
install_requires=[
"dataclasses_json==0.5.7",
"immutables",
"deprecated",
"immutables>=0.18",
"pytest",
"phonenumbers",
],
Expand Down