Skip to content

Update newsletter selector wording #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakithb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update newsletter selector wording #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf322cb
Update newsletter selector working
sakithb Mar 4, 2026
31d9b58
format
sakithb Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 4 additions & 23 deletions frontend/src/routes/console/@components/Nav/NewsletterList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,15 @@
<script lang="ts">
import { userNewslettersStore } from '../../lib/stores/userNewslettersStore';
import NewsletterRow from './NewsletterRow.svelte';

export let own = false;

const newsletters = own
? $userNewslettersStore.filter((p) => p.role == 'owner')
: $userNewslettersStore.filter((p) => p.role != 'owner');
</script>

{#if newsletters.length}
{#if $userNewslettersStore.length}
<div class="wrap">
<div class="title-wrap">
<div class="title">
{#if own}
Newsletters you own
{:else}
Newsletters you are admin
{/if}
</div>
<div class="description">
{#if own}
You are the owner of these newsletters. Your subscription applies to all of
them.
{:else}
You are admin on these websites. Your subscription does not apply to them.
{/if}
</div>
<div class="title">Newsletters you can access</div>
<div class="description">Your organization owns these newsletters.</div>
Copy link
Member

@supun-io supun-io Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely remove these two (title and desscription). Simply having the list is enough now, no message needed

</div>
{#each newsletters as newsletter}
{#each $userNewslettersStore as newsletter}
<NewsletterRow newsletterList={newsletter} />
{/each}
</div>
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/routes/console/@components/Nav/NewsletterSelector.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
{/snippet}

<div class="wrap">
<NewsletterList own={true} />
<NewsletterList own={false} />
<NewsletterList />
</div>
</Modal>
{/if}
Expand Down