Stores and uses internal cutoffs#12
Open
Ai0796 wants to merge 22 commits into
Open
Conversation
Contributor
Ai0796
commented
Aug 11, 2022
Ai0796
commented
- Added script to stored all cutoffs every minute (interval constant added to constants)
- Cutoffs are stored in a folder called cutoff-data (defined in constants) in the format cutoff-data/Event{eventNum}/{tier}.json in the same format as Sekai.best rankData.data.eventRankings
Interal cutoff storage
hzcafe
previously approved these changes
Aug 14, 2022
Owner
hzcafe
left a comment
hzcafe
left a comment
There was a problem hiding this comment.
Hi Ai0, please check out the comment I left for you.
Other than that, looks really great! Thank you so much for taking the time to help out with this project :)
Contributor
Author
|
I added database, data is being read, no large scale tests done so far, will be running one internally |
…boNene into Interal_Cutoff_Storage
Contributor
Author
|
I've confirmed nene robo cutoff tracking breaks in between events. Don't merge yet |
Contributor
Author
|
Tested for most of Mermaids and half of Moon Rabbits, seems to be no errors when event starts or ends anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.