soldoros_doll: strip [armor subtype] and remove ex2.act from [etc action]

[Copilot]

buildSupportSummonDollDocument was passing through [armor subtype] 4 and both action/ex.act + action/ex2.act from the source AIC into the generated doll document. The doll should omit the armor subtype entirely and only carry action/ex.act.

Changes

• packages/pvf-mod/src/equ.ts — adds removeTopLevelSection(document, name) utility (parallel to existing replaceTopLevelSection)
• mods/soldoros_doll/src/index.ts
  • Adds filterEtcAction() — strips any [etc action] statement whose token exactly matches action/ex2.act
  • buildSupportSummonDollDocument now pipes through removeTopLevelSection("armor subtype") → filterEtcAction()
• mods/soldoros_doll/src/index.test.ts — asserts [armor subtype] is absent, action/ex.act is present, and ex2.act does not appear in the doll overlay

export function buildSupportSummonDollDocument(sourceDocument: EquDocument): EquDocument {
  const withName = replaceMinimumInfoName(sourceDocument, SUPPORT_SUMMON_DOLL_NAME);
  const withDamageRate = replaceTopLevelSection(withName, createSingleFloatLiteralSection("attack damage rate", SUPPORT_SUMMON_ATTACK_DAMAGE_RATE));
  const withoutArmorSubtype = removeTopLevelSection(withDamageRate, "armor subtype");
  return filterEtcAction(withoutArmorSubtype);
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• plugins.dprint.dev
  • Triggering command: /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint fmt --allow-no-files -- /home/REDACTED/work/pvf/pvf/mods/soldoros_doll/src/index.test.ts /home/REDACTED/work/pvf/pvf/mods/soldoros_doll/src/index.ts /home/REDACTED/work/pvf/pvf/packages/pvf-mod/src/equ.ts k/_temp/ghcca-node/node/bin/git (dns block)
  • Triggering command: /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint fmt --allow-no-files -- /home/REDACTED/work/pvf/pvf/mods/soldoros_doll/src/index.test.ts /home/REDACTED/work/pvf/pvf/mods/soldoros_doll/src/index.ts /home/REDACTED/work/pvf/pvf/packages/pvf-mod/src/equ.ts ******"; }; f (dns block)
  • Triggering command: /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint /home/REDACTED/work/pvf/pvf/node_modules/.pnpm/dprint@0.53.2/node_modules/dprint/dprint fmt --allow-no-files packages/pvf-mod/src/equ.ts mods/soldoros_doll/src/index.ts mods/soldoros_doll/src/index.test.ts v6/conf/enP24323s1 ndor/bin/bash user.email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR updates the soldoros_doll mod’s AIC document generation to better match intended output: it removes the [armor subtype] top-level section entirely and ensures [etc action] does not include action/ex2.act.

Changes:

• Added a reusable removeTopLevelSection(document, name) helper in @pvf/pvf-mod.
• Updated buildSupportSummonDollDocument to remove [armor subtype] and filter out action/ex2.act from [etc action].
• Expanded the Soldoros doll integration test to assert the expected section/action behavior in the generated overlay.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/pvf-mod/src/equ.ts	Adds removeTopLevelSection utility for removing a named top-level section from an EquDocument.
mods/soldoros_doll/src/index.ts	Applies the new removal utility and introduces [etc action] filtering to exclude action/ex2.act.
mods/soldoros_doll/src/index.test.ts	Adds assertions that [armor subtype] is absent and ex2.act is not present while ex.act remains.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.