fix(keycloak-theme): force build to resolve React from package path#2353
fix(keycloak-theme): force build to resolve React from package path#2353
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request stabilizes the Keycloak theme's frontend by enforcing a consistent React runtime environment within the build. The changes prevent issues like blank login pages that arise from conflicting React versions or multiple instances of React being loaded, thereby ensuring both custom-themed and Keycloakify fallback pages function correctly across local and platform deployments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with mixed React runtimes in the Keycloak theme build by updating the Vite configuration. The changes introduce dedupe and alias properties to ensure a single instance of React is used. The implementation is sound, but I've suggested a couple of improvements to make the path resolution in the Vite config more robust by using require.resolve instead of hardcoding node_modules paths. This will make the build less likely to break with different package manager setups or in a monorepo environment.
Signed-off-by: Petr Kadlec <petr@puradesign.cz>
Signed-off-by: Petr Kadlec <petr@puradesign.cz>
ec8b1f9 to
ede40fb
Compare
Summary
Fixes Keycloak login blank page caused by mixed React runtimes in the keycloak-theme build.
The Vite config now dedupes and aliases react, react-dom and JSX runtime imports to the local package path, ensuring a single runtime in bundled assets - this keeps both custom-themed pages and Keycloakify fallback pages working consistently in local and platform deployments.
Linked Issues
Closes #2347
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.