Move ThemeFinder into consult as a uv workspace member#1287
Closed
jjuritzno10 wants to merge 18 commits intomainfrom
Closed
Move ThemeFinder into consult as a uv workspace member#1287jjuritzno10 wants to merge 18 commits intomainfrom
jjuritzno10 wants to merge 18 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copies the full themefinder codebase (src, tests, evals, docs, examples) as a subdirectory. Excludes .git/, .github/, and uv.lock — workspace lockfile will be generated in a subsequent commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Create root pyproject.toml with workspace config - Add workspace source for themefinder in backend/pyproject.toml - Delete backend/uv.lock in favor of root workspace lockfile - Generate new uv.lock resolving both workspace members Verified: uv sync succeeds, themefinder imports work from backend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pipelines will install themefinder from local source instead of PyPI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Both pipeline-sign-off and pipeline-mapping now COPY and pip install themefinder from the monorepo instead of pulling from PyPI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The uv-packages stage now copies the workspace root config, lockfile, and themefinder source so uv can resolve the workspace dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds evals/, docs/, tests/, examples/, architecture/ to .dockerignore to keep production image context small. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update make install to use workspace-level uv sync - Add make test-themefinder, test-all, run-evals targets Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The dev dependencies (pytest-asyncio, coverage, etc.) are defined in [project.optional-dependencies] not [dependency-groups], so uv needs --extra dev to make them available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
uv resolves relative UV_PROJECT_ENVIRONMENT paths from the workspace root, not the WORKDIR. Use absolute path /src/backend/venv so the venv lands where the app stage expects it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All core migration checks pass: workspace resolution, themefinder tests (82/82), backend tests (346 passed), and all 3 Docker builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
2 Open source vulnerabilities detected - high severity
Aikido detected 2 vulnerabilities across 2 packages, it includes 2 high vulnerabilities.
Details
Remediation Aikido suggests bumping the vulnerable packages to a safe version.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Author
|
Closing this as themefinder has moved on significantly in the past few days. Keeping the "PLAN" branch open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consult/themefinder/and wires it up as a uv workspace memberpipeline-sign-off,pipeline-mapping) install themefinder from local source viapip install ./themefinderuv syncwith rootpyproject.tomland lockfileuv.lockreplacesbackend/uv.locktest-themefinder,test-all, andrun-evalstargetsWhat changes
backend/uv.lockuv.lock(workspace-wide)pip install themefinder==X.Y.ZCOPY themefinder/ && pip install ./themefinderbackend/Verification (all pass locally)
uv syncworkspace resolutionfrom themefinder.models import ThemeNodemake test-themefindermake test-backenddocker build -f backend/Dockerfile .docker build -f pipeline-sign-off/Dockerfile .docker build -f pipeline-mapping/Dockerfile .Follow-up PRs
i-dot-ai/themefinderrepo in syncTest plan
make servestarts backend + frontend successfully🤖 Generated with Claude Code