Skip to content

Port memory printing on OpenBSD#493

Open
lucic71 wants to merge 14 commits into
i3:mainfrom
lucic71:feature/print_mem_openbsd
Open

Port memory printing on OpenBSD#493
lucic71 wants to merge 14 commits into
i3:mainfrom
lucic71:feature/print_mem_openbsd

Conversation

@lucic71

@lucic71 lucic71 commented Jul 21, 2022

Copy link
Copy Markdown
  • Split print_memory into get_memory_info which is platform dependent and print_formatted_memory which is platform independent
  • Created struct print_mem_info that keeps memory counters which will be passed between get_memory_info and print_formatted_memory
  • Used UVM subsystem to get memory counters on OpenBSD
  • Added the requirements in README
  • src/print_cpu_usage.c does not compile on OpenBSD because of the conditional definition of __OpenBSD__

@lucic71

lucic71 commented Jul 21, 2022

Copy link
Copy Markdown
Author

I still need to find a way to get buffers, cached and shared memory. If you have any idea how to do that it would be much appreciated.

@lucic71

lucic71 commented Jul 26, 2022

Copy link
Copy Markdown
Author

@stapelberg is this repo still active?

@stapelberg

Copy link
Copy Markdown
Member

Yes, this is still active, but I don’t really have time to answer development questions, sorry. I can try to review and merge your PR once you let me know it’s ready (it sounded like it wasn’t ready currently).

@lucic71

lucic71 commented Aug 11, 2022

Copy link
Copy Markdown
Author

@stapelberg, it's ready for reviewing!

@stapelberg

Copy link
Copy Markdown
Member

@stapelberg, it's ready for reviewing!

Thanks, this looks reasonable on first glance.

Can you format your code with clang-format to make the CI pass? Have you run the tests yet to ensure they pass, too?

@4nd3r 4nd3r mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants