cpu_usage: reuse previous values on rapid refreshes#559
Open
whoismz wants to merge 1 commit into
Open
Conversation
cpu_usage is calculated from the delta between two CPU time samples. When i3status is refreshed again before the configured interval has elapsed, the sampling window can be too small and the reported percentage becomes noisy. This can be observed when changing volume while both the volume and cpu_usage modules are enabled. Reuse the previous overall and per-CPU usage values for refreshes that happen before the configured interval, and avoid advancing the previous CPU sample in that case. This keeps CPU usage sampling aligned with the configured interval and avoids artificial spikes on rapid refreshes. Fixes i3#442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442.
cpu_usage is calculated from the delta between two CPU time samples. When i3status is refreshed again before the configured interval has elapsed, the sampling window can be too small and the reported percentage becomes noisy.
This can be observed when changing volume while both the volume and cpu_usage modules are enabled: changing the volume can cause cpu_usage to show an artificial spike.
This patch reuses the previous overall and per-CPU usage values for refreshes that happen before the configured interval, and avoids advancing the previous CPU sample in that case.
Tested on Arch Linux with i3, i3status, PipeWire/PulseAudio, and a config using both volume master and cpu_usage.