fix: preserve EIP712Challenge required to fetch compute logs#167
Merged
fix: preserve EIP712Challenge required to fetch compute logs#167
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the EIP-712 challenge representation and signing flow to ensure the serialized EIP712Challenge payload includes required fields (notably primaryType) for downstream use cases like fetching compute logs, while migrating token-building in tests to the newer EIP712TypedData-based signing.
Changes:
- Reworked
EIP712Challengeinto a dedicated JSON-serializable wrapper containingtypes,primaryType,domain, andmessage. - Added
SignerService#signTypedDataForDomainAndBuildToken(...)and updated signing tests to use typed-data signing instead of deprecatedEIP712Entitysigning. - Fixed a logging format typo in
SignerServiceand updated related JSON expectations in tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/iexec/commons/poco/eip712/entity/EIP712Challenge.java | Replaces the prior EIP712Entity-based implementation with an explicit wrapper to preserve required EIP-712 JSON structure. |
| src/main/java/com/iexec/commons/poco/chain/SignerService.java | Adds typed-data token builder and adjusts deprecation messaging; fixes log formatting typo. |
| src/test/java/com/iexec/commons/poco/eip712/entity/EIP712ChallengeTests.java | Updates expected JSON serialization string to match the new EIP712Challenge structure. |
| src/test/java/com/iexec/commons/poco/chain/SignerServiceTests.java | Migrates token-building test to the typed-data signing API (no longer uses EIP712Challenge). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Natchica
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.