Completed qodo-code actoin required changes - #2703
Open
GenCodeInc wants to merge 19 commits into
Open
Conversation
Add a lawnmower/grid survey pattern generator that allows users to define a polygon area on the map and automatically generate survey waypoints within it. Features: - Grid survey button in Action Menu with polygon drawing interaction - Sidebar settings card with line spacing, altitude, speed, sweep angle, overshoot, and End with RTH checkbox - Live auto-preview: polygon outline, dashed survey path, and numbered waypoint dots update as parameters change - Lawnmower pattern algorithm with configurable sweep angle and overshoot - RTH waypoint automatically appended when End with RTH is checked - Waypoint count display with remaining capacity - Ctrl+G keyboard shortcut to activate grid draw mode - Full i18n support for all UI strings
- Arrow keys (Left/Right) navigate between waypoints with card transition - Delete key removes selected waypoint with confirmation dialog - Auto-select previous waypoint after deletion - Auto-select WP1 after grid survey generation - Show 'Add WP' tooltip with crosshair when hovering flight path lines - Green RTH marker at last waypoint position for all missions - Ctrl+G keyboard shortcut for grid polygon draw
- SET_HEAD waypoints show black circle with white arrow pointing in heading direction - Heading degree label displayed below the marker - Heading marker and RTH marker render above flight path lines (zIndex: 99)
- SET_HEAD shows black circle with white directional dot (pure geometry, no text rotation) - RTH and heading markers aligned with WP pin center via MARKER_ICON_OFFSET_X/Y - Both marker circles same size (radius 10) - Offset constants adjustable: MARKER_ICON_OFFSET_Y=12, MARKER_ICON_OFFSET_X=-2
…issionGridPreview locale key
…ht#2593 # Conflicts: # locale/en/messages.json # tabs/mission_control.js
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoAdd grid survey generator and keyboard UX improvements to Mission Control
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
+4371
to
+4374
| const maxWp = mission.getMaxWaypoints(); | ||
| const totalCount = waypoints.length + ($('#gridEndRTH').is(':checked') ? 1 : 0); | ||
| const countText = i18n.getMessage('missionGridWaypointCount', [totalCount, maxWp]); | ||
| $('#gridWaypointCount').text(countText).css('color', totalCount > maxWp ? 'red' : '#666'); |
There was a problem hiding this comment.
2. Grid capacity text mismatch 🐞 Bug ≡ Correctness
updateGridPreview() interpolates missionGridWaypointCount with mission.getMaxWaypoints() as “remaining capacity”, so the displayed value does not match what the message string claims it represents.
Agent Prompt
## Issue description
The new English i18n string `missionGridWaypointCount` says `$2` is “remaining capacity”, but the preview code passes `mission.getMaxWaypoints()` (the maximum allowed waypoints) as `$2`. This yields misleading UI like “remaining capacity: 120” when it’s actually the limit, not remaining after the proposed grid.
## Issue Context
- `mission.getMaxWaypoints()` returns the configured maximum (not remaining slots).
- The preview computes `totalCount` already, so remaining can be computed if that’s what the UI intends.
## Fix Focus Areas
- tabs/mission_control.js[4371-4374]
- locale/en/messages.json[6825-6827]
- js/waypointCollection.js[21-27]
## Suggested fix (pick one)
1) If `$2` should be remaining after generating this grid: pass `maxWp - totalCount` (clamped at >= 0).
2) If `$2` should be the absolute limit: change the message text to “maximum capacity” / “limit” instead of “remaining capacity”.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
|
Configurator test build ready — commit Download build artifacts for PR #2703 Available platforms (scroll to the Artifacts section at the bottom of the run page):
|
Member
|
Just an FYI for contributors: The tentative schedule for INAV 10 is to have a full release in mid December. That means RC2 needs to be in early to mid November, which places INAV 10.0RC1 at September 1. Please plan to have any new features for INAV 10.0 ready for RC1 no later than September 1. After that, 10.1 will follow about six to seven months later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues found in code review
Completed qodo-code actoin required changes