Prevent concurrent iTwin API fetches#214
Merged
Merged
Conversation
The Stratakit data table requires pre-fetching all records in order to support client-side search. Previously in-progress HTTP requests would get aborted by next-page requests, resulting in `net::ERR_ABORTED`. This PR adds proper guards. We also add Storybook controls for toggling between different requestType and viewMode options for easier testing.
alexdunae
requested review from
aruniverse,
ben-polinsky,
kckst8 and
toddsouthenbentley
as code owners
toddsouthenbentley
approved these changes
Jun 17, 2026
kckst8
approved these changes
Jun 18, 2026
aruniverse
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses aborted iTwin API requests caused by overlapping pagination fetches by introducing a “fetch-in-progress” guard in the useITwinData hook, and adds Storybook controls to more easily test different requestType and viewMode combinations.
Changes:
- Initialize and reset the pagination guard (
fetchingMoreRef) in a “fetching” state to blockfetchMoreuntil the active request completes. - Add/extend hook tests to verify
fetchMoreis ignored during the initial request and works correctly after a request settles. - Add Storybook controls for
requestTypeandviewMode(plus defaults) across iTwin/iModel Grid stories.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinData.ts | Starts the fetch guard in a “fetching” state and sets it on refetch to prevent concurrent pagination requests. |
| packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinData.test.ts | Adds regression tests validating fetchMore behavior during/after the initial request. |
| packages/apps/storybook/src/imodel-browser/mui/ITwinGridMUI.stories.tsx | Adds Storybook controls for viewMode and requestType and sets a default requestType. |
| packages/apps/storybook/src/imodel-browser/mui/IModelGridMUI.stories.tsx | Adds Storybook controls for viewMode and requestType and sets a default requestType. |
| packages/apps/storybook/src/imodel-browser/ITwinGrid.stories.tsx | Adds Storybook controls for viewMode and requestType and sets a default requestType. |
| packages/apps/storybook/src/imodel-browser/IModelGrid.stories.tsx | Adds Storybook controls for viewMode and requestType and sets a default requestType. |
| common/changes/@itwin/imodel-browser-react/alex-itwin-tableview-fixes_2026-06-16-17-50.json | Adds a patch changeset entry for the iModel browser React package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stratakit data table requires pre-fetching all records in order to support client-side search. Previously in-progress HTTP requests would get aborted by next-page requests, resulting in
net::ERR_ABORTED.This PR adds proper guards.
We also add Storybook controls for toggling between different
requestTypeandviewModeoptions for easier testing.