Fix Stratakit storybook icons when built#216
Merged
Merged
Conversation
Built Storybook was not rendering Stratakit's SVG icons when deployed to Github pages due to the `/admin-components-react/` path. This PR removes `publicPath` so Storybook can be built and deployed in any directory.
toddsouthenbentley
approved these changes
Jun 17, 2026
Member
|
Why strata icons cannot be rendered in subpaths? Does it mean hosting apps will have similar problems? |
Contributor
Author
They definitely can ben
This is just a Storybook-specific setting for SVGs added recently by me. It incorrectly assumed Storybook always ran in root. It won't affect icons (or anything) outside of Storybook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built Storybook is not rendering Stratakit's SVG icons when deployed to Github pages due to the
/admin-components-react/path.This PR removes
publicPathso Storybook can be built and deployed in any directory.