Skip to content

Increase default page size for Stratakit components #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexdunae wants to merge 1 commit into from
Closed

Increase default page size for Stratakit components #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...anges/@itwin/imodel-browser-react/alex-stratakit-fetch-enhancements_2026-06-17-21-46.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/imodel-browser-react",
"comment": "Increase default page size for Stratakit components",
"type": "patch"
}
],
"packageName": "@itwin/imodel-browser-react"
}
9 changes: 6 additions & 3 deletions packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ export interface ProjectDataHookOptions {
orderbyOptions?: string;
shouldRefetchFavorites?: boolean;
resetShouldRefetchFavorites?: () => void;
pageSize?: number;
}

const PAGE_SIZE = 100;
const DEFAULT_PAGE_SIZE = 100;

export const useITwinData = ({
requestType = "",
Expand All @@ -37,6 +38,7 @@ export const useITwinData = ({
orderbyOptions,
shouldRefetchFavorites,
resetShouldRefetchFavorites,
pageSize = DEFAULT_PAGE_SIZE,
}: ProjectDataHookOptions) => {
const data = apiOverrides?.data;
const serverEnvironmentPrefix = apiOverrides?.serverEnvironmentPrefix;
Expand Down Expand Up @@ -115,7 +117,7 @@ export const useITwinData = ({
: "";
const resolvedITwinSubClass = iTwinSubClass === "All" ? "" : iTwinSubClass;
const subClass = `?subClass=${resolvedITwinSubClass}`;
const paging = `&$skip=${page * PAGE_SIZE}&$top=${PAGE_SIZE}`;
const paging = `&$skip=${page * pageSize}&$top=${pageSize}`;
const search =
["favorites", "recents"].includes(requestType) || !filterOptions
? ""
Expand Down Expand Up @@ -155,7 +157,7 @@ export const useITwinData = ({
setStatus(DataStatus.Complete);
fetchingMoreRef.current = false;
requestType === "favorites" && resetShouldRefetchFavorites?.();
if (result.iTwins.length !== PAGE_SIZE) {
if (result.iTwins.length !== pageSize) {
setMorePages(false);
}
setProjects((projects) =>
Expand Down Expand Up @@ -188,6 +190,7 @@ export const useITwinData = ({
iTwinSubClass,
shouldRefetchFavorites,
resetShouldRefetchFavorites,
pageSize,
]);
return {
iTwins: filteredProjects,
Expand Down
3 changes: 3 additions & 0 deletions packages/modules/imodel-browser/src/mui/containers/ITwinGrid/ITwinGridMUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { stripNonTileProps } from "../../utils/stripNonTileProps";
import { type ITwinTableMUIStrings, ITwinTableMUI } from "./ITwinTableMUI";
import { type ITwinTilePropsMUI, ITwinTileMUI } from "./ITwinTileMUI";

const DEFAULT_PAGE_SIZE = 250;

/** @alpha */
export type IndividualITwinStateHookMUI = (
iTwin: ITwinFull,
Expand Down Expand Up @@ -161,6 +163,7 @@ export const ITwinGridMUI = ({
orderbyOptions,
shouldRefetchFavorites,
resetShouldRefetchFavorites,
pageSize: DEFAULT_PAGE_SIZE,
});

const iTwins = React.useMemo(
Expand Down
9 changes: 4 additions & 5 deletions packages/modules/imodel-browser/src/mui/containers/iModelGrid/IModelGridMUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ import React from "react";
import { InView } from "react-intersection-observer";

import type { IModelGridProps } from "../../../containers/iModelGrid/IModelGrid";
import {
DEFAULT_PAGE_SIZE,
useIModelData,
} from "../../../containers/iModelGrid/useIModelData";
import { useIModelData } from "../../../containers/iModelGrid/useIModelData";
import { IModelFavoritesProvider } from "../../../contexts/IModelFavoritesContext";
import {
type AccessTokenProvider,
Expand Down Expand Up @@ -40,6 +37,8 @@ import {
import { clientSideIModelSort } from "./clientSideIModelSort";
import { type IModelTableMUIStrings, IModelTableMUI } from "./IModelTableMUI";

const DEFAULT_PAGE_SIZE = 250;

/**
* Localized strings for the MUI IModelGrid. Extends the table-level strings
* with the grid-level messages used for empty, error, and authentication states.
Expand Down Expand Up @@ -243,7 +242,7 @@ const IModelGridInternal = ({
sortOptions: sort,
searchText,
maxCount,
pageSize,
pageSize: DEFAULT_PAGE_SIZE,
viewMode,
dataMode,
onLoadMore,
Expand Down
Loading