Skip to content

Use server sorting for Stratakit table components #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexdunae wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use server sorting for Stratakit table components #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1727c3
Use server sorting for Stratakit table components
alexdunae Jun 18, 2026
f779dcf
Merge branch 'main' into disable-stratakit-tablesort
alexdunae Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@itwin/imodel-browser-react/disable-stratakit-tablesort_2026-06-18-16-22.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/imodel-browser-react",
"comment": "Use server sorting for Stratakit table components",
"type": "patch"
}
],
"packageName": "@itwin/imodel-browser-react"
}
33 changes: 31 additions & 2 deletions packages/apps/storybook/src/imodel-browser/mui/IModelGridMUI.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,37 @@ export const IModelGridMUI = (props: IModelGridMUIProps) => (
export default {
title: "imodel-browser/IModelGridMUI",
component: IModelGridMUI,
argTypes: accessTokenArgTypes,
argTypes: {
...accessTokenArgTypes,
sortOptions: {
control: "radio",
options: [
"name asc",
"name desc",
"createdDateTime asc",
"createdDateTime desc",
],
mapping: {
"name asc": { sortType: "name", descending: false },
"name desc": { sortType: "name", descending: true },
"createdDateTime asc": {
sortType: "createdDateTime",
descending: false,
},
"createdDateTime desc": {
sortType: "createdDateTime",
descending: true,
},
},
},
searchText: {
description: "Search text",
control: "text",
},
},
args: {
sortOptions: "name asc",
},
excludeStories: ["IModelGridMUI"],
} as Meta;

Expand All @@ -48,7 +78,6 @@ const Template: Story<IModelGridMUIProps> = withITwinIdOverride(

const baseArgs: IModelGridMUIProps = {
apiOverrides: { serverEnvironmentPrefix: "qa" },
sortOptions: { sortType: "name", descending: false },
actions: [
{
key: "open",
Expand Down
20 changes: 20 additions & 0 deletions packages/apps/storybook/src/imodel-browser/mui/ITwinGridMUI.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,26 @@ export default {
component: ITwinGrid,
argTypes: {
accessToken,
orderbyOptions: {
control: "radio",
options: [
"displayName asc",
"displayName desc",
"number asc",
"number desc",
"createdDateTime asc",
"createdDateTime desc",
"lastModifiedDateTime asc",
"lastModifiedDateTime desc",
],
},
filterOptions: {
description: "Search text",
control: "text",
},
},
args: {
orderbyOptions: "displayName asc",
},
excludeStories: ["ITwinGrid"],
} as Meta;
1 change: 1 addition & 0 deletions packages/modules/imodel-browser/src/mui/containers/ITwinGrid/ITwinTableMUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ export const ITwinTableMUI = ({
}
disableRowSelectionOnClick
disableMultipleRowSelection
disableColumnSorting
disableColumnSelector
disableColumnFilter
initialState={{
Expand Down
34 changes: 9 additions & 25 deletions packages/modules/imodel-browser/src/mui/containers/iModelGrid/IModelGridMUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import {
type IModelTileMUIProps,
IModelTileMUI,
} from "../iModelTiles/IModelTileMUI";
import { clientSideIModelSort } from "./clientSideIModelSort";
import { type IModelTableMUIStrings, IModelTableMUI } from "./IModelTableMUI";

/**
Expand Down Expand Up @@ -153,18 +152,11 @@ const IModelGridInternal = ({
const [sort, setSort] = React.useState<IModelSortOptions>(sortOptions);

React.useEffect(() => {
setSort(
viewMode === "cells"
? {
sortType: "name",
descending: false,
}
: {
sortType: sortOptions.sortType,
descending: sortOptions.descending,
}
);
}, [sortOptions.descending, sortOptions.sortType, viewMode]);
setSort({
sortType: sortOptions.sortType,
descending: sortOptions.descending,
});
}, [sortOptions.descending, sortOptions.sortType]);

const strings = React.useMemo(
() =>
Expand Down Expand Up @@ -251,19 +243,11 @@ const IModelGridInternal = ({
});

const iModels = React.useMemo(() => {
const processed =
return (
postProcessCallback?.([...fetchediModels], fetchStatus, searchText) ??
fetchediModels;
return clientSideIModelSort(processed, { viewMode, requestType, sort });
}, [
postProcessCallback,
fetchediModels,
fetchStatus,
searchText,
viewMode,
requestType,
sort,
]);
fetchediModels
);
}, [postProcessCallback, fetchediModels, fetchStatus, searchText]);

React.useEffect(() => {
if (
Expand Down
1 change: 1 addition & 0 deletions packages/modules/imodel-browser/src/mui/containers/iModelGrid/IModelTableMUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ export const IModelTableMUI = ({
}
disableRowSelectionOnClick
disableMultipleRowSelection
disableColumnSorting
disableColumnSelector
disableColumnFilter
initialState={{
Expand Down
44 changes: 0 additions & 44 deletions packages/modules/imodel-browser/src/mui/containers/iModelGrid/clientSideIModelSort.ts
View file
Open in desktop

This file was deleted.

Loading