Concurrency issue when decrypting/encrypting by keystore keys#46
Open
jayjaykim wants to merge 15 commits intoiamMehedi:masterfrom
Open
Concurrency issue when decrypting/encrypting by keystore keys#46jayjaykim wants to merge 15 commits intoiamMehedi:masterfrom
jayjaykim wants to merge 15 commits intoiamMehedi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's a concurrency issue while decrypting/encrypting something by keystore keys at the same time like below. So I added some code fragments that you can test it and added synchronization and retry logic to resolve the issue. Please review it seriously.
It is my app's most serious issue.
you can calibrate sleep time in retry logic. It seems like just 1 nano seconds also works like charm...
2018-12-27 14:12:20.278 14509-14624/devliving.online.securedpreferencestoresample W/System.err: javax.crypto.IllegalBlockSizeException
2018-12-27 14:12:20.278 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at android.security.keystore.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:519)
2018-12-27 14:12:20.278 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at javax.crypto.Cipher.doFinal(Cipher.java:1736)
2018-12-27 14:12:20.278 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestore.EncryptionManager.encryptAES(EncryptionManager.java:404)
2018-12-27 14:12:20.278 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestore.EncryptionManager.encrypt(EncryptionManager.java:245)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestore.EncryptionManager.tryEncrypt(EncryptionManager.java:178)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestore.EncryptionManager.encrypt(EncryptionManager.java:290)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestore.SecuredPreferenceStore$Editor.putString(SecuredPreferenceStore.java:299)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestoresample.MainActivity.saveData(MainActivity.java:161)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at devliving.online.securedpreferencestoresample.MainActivity$3$1.run(MainActivity.java:84)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at java.lang.Thread.run(Thread.java:764)
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: Caused by: android.security.KeyStoreException: Invalid operation handle
2018-12-27 14:12:20.279 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at android.security.KeyStore.getKeyStoreException(KeyStore.java:1137)
2018-12-27 14:12:20.280 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at android.security.keystore.KeyStoreCryptoOperationChunkedStreamer.update(KeyStoreCryptoOperationChunkedStreamer.java:132)
2018-12-27 14:12:20.280 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at android.security.keystore.KeyStoreCryptoOperationChunkedStreamer.doFinal(KeyStoreCryptoOperationChunkedStreamer.java:217)
2018-12-27 14:12:20.280 14509-14624/devliving.online.securedpreferencestoresample W/System.err: at android.security.keystore.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:506)
2018-12-27 14:12:20.280 14509-14624/devliving.online.securedpreferencestoresample W/System.err: ... 9 more (edited)