Skip to content

Task 1#3

Open
Msknsngla wants to merge 2 commits intoiamarchisha:masterfrom
Msknsngla:master
Open

Task 1#3
Msknsngla wants to merge 2 commits intoiamarchisha:masterfrom
Msknsngla:master

Conversation

@Msknsngla
Copy link
Copy Markdown

@Msknsngla Msknsngla commented Jun 13, 2020

Fixes #2
Notebook for task 1 and the data used.

@iamarchisha iamarchisha added the changes requested Make changes requested to commit label Jun 14, 2020
Copy link
Copy Markdown
Owner

@iamarchisha iamarchisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the notebook, after performing any action comment on the results obtained. Explain the observation or the output that you are getting after executing the cell. Eg: df.corr returns a correlation matrix, so explain what can be inferred from the result obtained. What does it show? Which features are correlated? What can be the reason? What further action can be taken on them?

The csv is to be re-used or if you are using a new dataset, add it to the /data folder with an appropriate name. Also, rename the notebook. Work on a separate branch. Do not use origin:master

Copy link
Copy Markdown
Owner

@iamarchisha iamarchisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is very good. You have clearly documented all the functions being executed in the cell. The inferences are good. Great job on completing the first issue!

Just keep Task1(Train and Test a model).ipynb in the pull-request. Remove the other files. Read the csv file from the one stored in the data folder. Note for future contributions: use a separate branch instead of master. It helps keep a track of work and make changes easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Make changes requested to commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Train and test a model

2 participants