test(mcp-config): add --claude-code path tests#173
Conversation
Cover the writeClaudeCodeConfig function which was untested: - Creates settings.json when file does not exist - Merges into existing settings without overwriting other keys - Reports 'already configured' when memex entry exists - Idempotent — running twice does not duplicate config - Creates .claude directory if it does not exist
|
Hi 👋 Friendly check-in — this PR has been open for a week. Let me know if there's anything I should change or if this looks good to merge! |
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate a review when you get a chance. Happy to adjust anything if needed. Thanks! 🙏 |
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate any feedback or review when you have time. Happy to adjust if anything needs changing! |
|
Hi 👋 Friendly check-in — this PR has been open for over a week. Would appreciate any feedback when you have a moment. Happy to adjust if needed! |
|
Hi — same note as #174: approaching 2 weeks without review. Will close in a few days if no activity. Happy to reopen later if needed. 🙂 |
|
Closing this PR as it's been open for 12 days without any maintainer feedback. The tests are ready to go — happy to reopen or recreate if you'd like to merge later. Thanks! 🙏 |
1 participant
Summary
Add 5 test cases for the
--claude-codepath inconfigureMcp, which was previously untested.New Tests
.claude/dir and file created correctlymodel, othermcpServers)mkdir({ recursive: true })works for missing parent dirHow tested
Tests use a temp directory with
HOMEoverride to avoid touching the real~/.claude/settings.json.