Correction in syntax changes to support Python 3#20
Open
evolentini wants to merge 3 commits intoianepperson:masterfrom
Open
Correction in syntax changes to support Python 3#20evolentini wants to merge 3 commits intoianepperson:masterfrom
evolentini wants to merge 3 commits intoianepperson:masterfrom
Conversation
|
@ianepperson please merge this and update pypi |
|
Seems project is DOA. Might be worth making a new project and sending up to pypi. |
|
@coolacid I'm also interested in porting it to python3. Anyone? Can we setup a fork/new project to work on? |
|
I have forked it to Blindfreddy/telnetsrvlib. Guess we now need to merge the python3 mods made by evoltini. |
|
and then upload to PyPI... |
Blindfreddy
approved these changes
Oct 22, 2019
gregormaclaine
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am developing a project with Python 3 and I needed a Telnet server. I found your library that I liked a lot, but doing tests I saw that it did not work in Python 3, only in version 2. I made any corrections and now it works in both versions. I personally tried the gevent and thread versions in python 2.7 and 3.6, and although I made a change in the version with ssh, I did not prove that it works, just that it does not generate a syntax error.
I thought you might be interested in reviewing the changes and adding them to the stable version.
regards
Esteban