CC-1: Implement Astro Site#335
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR refactors the landing page into a redirect-only component while introducing external navigation support. It extends the settings configuration with external URLs for documentation, Discord, and Buy Me a Coffee, creates a new reusable Discord icon component, and wires these into the App navigation to display a "Support" section with external links. The landing page now conditionally redirects authenticated users to the dashboard and unauthenticated users to published tournaments. Supporting changes include CSS variable reorganization and targeted dependency version bumps. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/SocialIconDiscord/SocialIconDiscord.tsx`:
- Around line 7-27: The SocialIconDiscord component currently accepts a
strokeWidth prop and spreads SVG stroke attributes on the <svg> but the inner
<path> uses fill="currentColor", so strokeWidth has no effect; fix by making the
component consistent: either remove the stroke-related props and attributes
(remove stroke, strokeWidth, strokeLinecap, strokeLinejoin, and the strokeWidth
prop from SocialIconDiscord's props) to treat it as a purely filled icon, or
convert the path to a stroked path (replace fill with stroke="currentColor" and
adjust path data as needed) so strokeWidth actually controls appearance; update
the SocialIconDiscord declaration and its prop types (and any usages)
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8d9fc410-f67b-4fa6-b28d-a832ea24cdfc
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
package.jsonsrc/components/App/App.tsxsrc/components/SocialIconDiscord/SocialIconDiscord.tsxsrc/components/SocialIconDiscord/index.tssrc/pages/LandingPage/LandingPage.module.scsssrc/pages/LandingPage/LandingPage.tsxsrc/pages/LandingPage/index.tssrc/settings.tssrc/style/_variables.scss
💤 Files with no reviewable changes (2)
- src/pages/LandingPage/LandingPage.module.scss
- src/style/_variables.scss
Comment on lines
+7
to
+27
| export const SocialIconDiscord = forwardRef<SVGSVGElement, SocialIconDiscordProps>(({ | ||
| size = 24, | ||
| strokeWidth = 2, | ||
| ...props | ||
| }, ref) => ( | ||
| <svg | ||
| ref={ref} | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| viewBox="0 0 24 24" | ||
| width={size} | ||
| height={size} | ||
| fill="none" | ||
| stroke="currentColor" | ||
| strokeWidth={strokeWidth} | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| {...props} | ||
| > | ||
| <path fill="currentColor" d="M19.303 5.337A17.3 17.3 0 0 0 14.963 4c-.191.329-.403.775-.552 1.125a16.6 16.6 0 0 0-4.808 0C9.454 4.775 9.23 4.329 9.05 4a17 17 0 0 0-4.342 1.337C1.961 9.391 1.218 13.35 1.59 17.255a17.7 17.7 0 0 0 5.318 2.664a13 13 0 0 0 1.136-1.836c-.627-.234-1.22-.52-1.794-.86c.149-.106.297-.223.435-.34c3.46 1.582 7.207 1.582 10.624 0c.149.117.287.234.435.34c-.573.34-1.167.626-1.793.86a13 13 0 0 0 1.135 1.836a17.6 17.6 0 0 0 5.318-2.664c.457-4.52-.722-8.448-3.1-11.918M8.52 14.846c-1.04 0-1.889-.945-1.889-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.888 2.102c0 1.156-.838 2.1-1.889 2.1m6.974 0c-1.04 0-1.89-.945-1.89-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.889 2.102c0 1.156-.828 2.1-1.89 2.1" /> | ||
| </svg> | ||
| )); |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
The strokeWidth prop has no effect on the rendered icon.
The SVG wrapper applies stroke styling (lines 19-22), but the path inside uses fill="currentColor" (line 25) rather than stroke. This makes the strokeWidth prop misleading—it's accepted but doesn't control the icon's appearance.
Consider either:
- Removing the
strokeWidthprop and stroke-related SVG attributes if this icon is fill-based - Or converting the path to use stroke instead of fill so
strokeWidthactually controls the icon thickness
♻️ Option 1: Remove unused stroke props (recommended if icon should stay fill-based)
interface SocialIconDiscordProps extends SVGProps<SVGSVGElement> {
size?: string | number;
- strokeWidth?: string | number;
}
export const SocialIconDiscord = forwardRef<SVGSVGElement, SocialIconDiscordProps>(({
size = 24,
- strokeWidth = 2,
...props
}, ref) => (
<svg
ref={ref}
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
width={size}
height={size}
- fill="none"
- stroke="currentColor"
- strokeWidth={strokeWidth}
- strokeLinecap="round"
- strokeLinejoin="round"
{...props}
>
<path fill="currentColor" d="M19.303 5.337A17.3 17.3 0 0 0 14.963 4c-.191.329-.403.775-.552 1.125a16.6 16.6 0 0 0-4.808 0C9.454 4.775 9.23 4.329 9.05 4a17 17 0 0 0-4.342 1.337C1.961 9.391 1.218 13.35 1.59 17.255a17.7 17.7 0 0 0 5.318 2.664a13 13 0 0 0 1.136-1.836c-.627-.234-1.22-.52-1.794-.86c.149-.106.297-.223.435-.34c3.46 1.582 7.207 1.582 10.624 0c.149.117.287.234.435.34c-.573.34-1.167.626-1.793.86a13 13 0 0 0 1.135 1.836a17.6 17.6 0 0 0 5.318-2.664c.457-4.52-.722-8.448-3.1-11.918M8.52 14.846c-1.04 0-1.889-.945-1.889-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.888 2.102c0 1.156-.838 2.1-1.889 2.1m6.974 0c-1.04 0-1.89-.945-1.89-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.889 2.102c0 1.156-.828 2.1-1.89 2.1" />
</svg>
));📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| export const SocialIconDiscord = forwardRef<SVGSVGElement, SocialIconDiscordProps>(({ | |
| size = 24, | |
| strokeWidth = 2, | |
| ...props | |
| }, ref) => ( | |
| <svg | |
| ref={ref} | |
| xmlns="http://www.w3.org/2000/svg" | |
| viewBox="0 0 24 24" | |
| width={size} | |
| height={size} | |
| fill="none" | |
| stroke="currentColor" | |
| strokeWidth={strokeWidth} | |
| strokeLinecap="round" | |
| strokeLinejoin="round" | |
| {...props} | |
| > | |
| <path fill="currentColor" d="M19.303 5.337A17.3 17.3 0 0 0 14.963 4c-.191.329-.403.775-.552 1.125a16.6 16.6 0 0 0-4.808 0C9.454 4.775 9.23 4.329 9.05 4a17 17 0 0 0-4.342 1.337C1.961 9.391 1.218 13.35 1.59 17.255a17.7 17.7 0 0 0 5.318 2.664a13 13 0 0 0 1.136-1.836c-.627-.234-1.22-.52-1.794-.86c.149-.106.297-.223.435-.34c3.46 1.582 7.207 1.582 10.624 0c.149.117.287.234.435.34c-.573.34-1.167.626-1.793.86a13 13 0 0 0 1.135 1.836a17.6 17.6 0 0 0 5.318-2.664c.457-4.52-.722-8.448-3.1-11.918M8.52 14.846c-1.04 0-1.889-.945-1.889-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.888 2.102c0 1.156-.838 2.1-1.889 2.1m6.974 0c-1.04 0-1.89-.945-1.89-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.889 2.102c0 1.156-.828 2.1-1.89 2.1" /> | |
| </svg> | |
| )); | |
| export const SocialIconDiscord = forwardRef<SVGSVGElement, SocialIconDiscordProps>(({ | |
| size = 24, | |
| ...props | |
| }, ref) => ( | |
| <svg | |
| ref={ref} | |
| xmlns="http://www.w3.org/2000/svg" | |
| viewBox="0 0 24 24" | |
| width={size} | |
| height={size} | |
| {...props} | |
| > | |
| <path fill="currentColor" d="M19.303 5.337A17.3 17.3 0 0 0 14.963 4c-.191.329-.403.775-.552 1.125a16.6 16.6 0 0 0-4.808 0C9.454 4.775 9.23 4.329 9.05 4a17 17 0 0 0-4.342 1.337C1.961 9.391 1.218 13.35 1.59 17.255a17.7 17.7 0 0 0 5.318 2.664a13 13 0 0 0 1.136-1.836c-.627-.234-1.22-.52-1.794-.86c.149-.106.297-.223.435-.34c3.46 1.582 7.207 1.582 10.624 0c.149.117.287.234.435.34c-.573.34-1.167.626-1.793.86a13 13 0 0 0 1.135 1.836a17.6 17.6 0 0 0 5.318-2.664c.457-4.52-.722-8.448-3.1-11.918M8.52 14.846c-1.04 0-1.889-.945-1.889-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.888 2.102c0 1.156-.838 2.1-1.889 2.1m6.974 0c-1.04 0-1.89-.945-1.89-2.101s.828-2.102 1.89-2.102c1.05 0 1.91.945 1.889 2.102c0 1.156-.828 2.1-1.89 2.1" /> | |
| </svg> | |
| )); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/SocialIconDiscord/SocialIconDiscord.tsx` around lines 7 - 27,
The SocialIconDiscord component currently accepts a strokeWidth prop and spreads
SVG stroke attributes on the <svg> but the inner <path> uses
fill="currentColor", so strokeWidth has no effect; fix by making the component
consistent: either remove the stroke-related props and attributes (remove
stroke, strokeWidth, strokeLinecap, strokeLinejoin, and the strokeWidth prop
from SocialIconDiscord's props) to treat it as a purely filled icon, or convert
the path to a stroked path (replace fill with stroke="currentColor" and adjust
path data as needed) so strokeWidth actually controls appearance; update the
SocialIconDiscord declaration and its prop types (and any usages) accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores
Style