feat(update): theme-aware update banner + indicator#396
Open
patschmittdev wants to merge 1 commit into
Open
Conversation
Split the desktop-updater chrome out of feat/webgl-ambient-background onto the ui-foundation base: - UpdateBanner: dismissible "ready to install" banner with restart action - UpdateIndicator: activity-bar update status affordance Fold in the P1 contrast fix: the banner previously hardcoded a yellow palette (text-yellow-100 was invisible in light mode). It now uses the --color-warning / --color-warning-foreground design tokens, so it stays legible in both light and dark themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Theme-aware auto-updater chrome, split off
feat/webgl-ambient-backgroundonto therefactor/ui-foundationbase (#389).Contents (4 files, +347/-27)
Stack
Sibling on
refactor/ui-foundation(#389). Note: theUpdateBannermount inAppShellis part of the final integration PR.Validation
npm run lint-- green (tsc, eslint, dependency-cruiser, yaml, md).