Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Maven Central Repository
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 20
server-id: ossrh
server-id: central
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
gpg-passphrase: MAVEN_GPG_PASSPHRASE
Expand Down
20 changes: 0 additions & 20 deletions .github/workflows/coverage.yml

This file was deleted.

7 changes: 4 additions & 3 deletions .github/workflows/publish_on_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ jobs:
publish:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Maven Central Repository
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 20
server-id: ossrh
server-id: central
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
gpg-passphrase: MAVEN_GPG_PASSPHRASE
Expand Down
46 changes: 8 additions & 38 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@
<id>api.wiki</id>
<url>https://github.com/ibanity/ibanity-java/wiki</url>
</site>
<snapshotRepository>
<id>ossrh</id>
<url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
<repository>
<id>ossrh</id>
<url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
</distributionManagement>

<developers>
Expand All @@ -55,7 +47,7 @@

<properties>
<!-- Artifact Version parts -->
<revision>6.1</revision>
<revision>6.2</revision>
<changelist>-SNAPSHOT</changelist>
<timestamp>${maven.build.timestamp}</timestamp>

Expand Down Expand Up @@ -83,7 +75,7 @@

<!-- Maven Pluging Version -->
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<nexus-staging-maven-plugin.version>1.6.13</nexus-staging-maven-plugin.version>
<central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
<maven-source-plugin.version>3.0.1</maven-source-plugin.version>
<maven-javadoc-plugin.version>3.2.0</maven-javadoc-plugin.version>
<maven-deploy-plugin.version>2.8.2</maven-deploy-plugin.version>
Expand All @@ -99,14 +91,6 @@
<mockito.version>4.3.1</mockito.version>
<assertj.version>3.22.0</assertj.version>

<!-- Sonar -->
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<sonar.organization>ibanity</sonar.organization>
<sonar.projectKey>com.ibanity.apis:ibanity-java</sonar.projectKey>
<sonar.language>java</sonar.language>
<sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
<sonar.version>3.9.1.2184</sonar.version>

</properties>

<dependencies>
Expand Down Expand Up @@ -238,11 +222,6 @@

<build>
<plugins>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${sonar.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
Expand All @@ -267,24 +246,15 @@
</executions>
</plugin>
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>${nexus-staging-maven-plugin.version}</version>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<version>${central-publishing-maven-plugin.version}</version>
<extensions>true</extensions>
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
<autoReleaseAfterClose>true</autoReleaseAfterClose>
<publishingServerId>central</publishingServerId>
<autoPublish>true</autoPublish>
<waitUntil>published</waitUntil>
</configuration>
<executions>
<execution>
<id>default-deploy</id>
<phase>deploy</phase>
<goals>
<goal>deploy</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
24 changes: 0 additions & 24 deletions sonar-project.properties

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.ibanity.apis.client.products.isabel_connect.models;

import com.fasterxml.jackson.annotation.JsonFormat;
import lombok.AccessLevel;
import lombok.AllArgsConstructor;
import lombok.Data;
Expand All @@ -20,7 +19,6 @@ public class Balance {
private String selfLink;
private String requestId;

@JsonFormat(pattern = "yyyy-MM-dd'T'HH:mm:ss.SSS", timezone = "UTC")
private LocalDateTime datetime;
private BigDecimal amount;
private String subtype;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,22 @@ public void list() throws Exception {
assertThat(actual.getPagingTotal()).isEqualTo(4);
}

@Test
public void listWithVariablePrecisionDatetimes() throws Exception {
when(ibanityHttpClient.get(new URI(LIST_BALANCES_ENDPOINT), emptyMap(), ACCESS_TOKEN))
.thenReturn(loadHttpResponse("json/isabel-connect/balances_variable_precision.json"));

IsabelCollection<Balance> actual = balanceService.list(BalancesReadQuery.builder()
.accountId(ACCOUNT_ID)
.accessToken(ACCESS_TOKEN)
.build());

assertThat(actual.getItems()).extracting(Balance::getDatetime)
.containsExactly(
LocalDateTime.parse("2026-07-09T00:00:00"),
LocalDateTime.parse("2026-07-10T09:23:40.987445389"));
}

private Balance createExpected() {
return Balance.builder()
.datetime(LocalDateTime.parse("2018-10-12T22:46:32.417"))
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"data": [
{
"attributes": {
"amount": 100.00,
"datetime": "2026-07-09T00:00:00",
"subtype": "CLBD"
},
"type": "balance"
},
{
"attributes": {
"amount": 200.00,
"datetime": "2026-07-10T09:23:40.987445389",
"subtype": "CLBD"
},
"type": "balance"
}
],
"meta": {
"paging": {
"offset": 0,
"total": 2
}
}
}
Loading