IBX-12102: Fixed SiteAccess context being lost after fragment sub-requests - #802
Open
tbialcz wants to merge 2 commits into
Open
IBX-12102: Fixed SiteAccess context being lost after fragment sub-requests#802tbialcz wants to merge 2 commits into
tbialcz wants to merge 2 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk and
wiewiurdp
and removed request for
a team
August 10, 2026 05:24
tbialcz
force-pushed
the
IBX-12102-siteaccess-not-restored-after-fragment-sub-request
branch
2 times, most recently
from
August 10, 2026 05:31
6b7eb3c to
b070c59
Compare
tbialcz
force-pushed
the
IBX-12102-siteaccess-not-restored-after-fragment-sub-request
branch
from
August 10, 2026 05:32
b070c59 to
abce25a
Compare
Contributor
|
Makes sense. Note (to self mostly) that #798 (6.0) will need slight adjustments once this lands. |
Contributor
Author
konradoboza
approved these changes
Aug 10, 2026
barw4
approved these changes
Aug 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
In Page Builder, every URL generated after a page block (or any
render_esi) lost theSiteAccess prefix, e.g.
//instead of/site_fr/.Why it happened:
it back when the fragment finished. Fixed with a new
kernel.finish_requestlistenerthat brings back the parent request's SiteAccess (same as Symfony does for its router).
URIElementmatcher computed its URI elements, so after deserialization the matcherproduced
//. Now the elements are computed before serialization.Origin: (1) is as old as the SiteAccess matching layer itself; (2) came with EZP-31810
(Sep 2020), which started serializing the raw, lazily-initialized property.
For QA:
site_frsiteaccess (URI matching) and put{{ path('ibexa.url.alias', { locationId: 2 }) }}at the end ofpagelayout.html.twig.site_fr: without a block, then add a block,publish and edit again.
/site_fr/(before the fix://once a block is on the page).Documentation:
None.