Skip to content

IBX-12192: Skip SiteAccessStamp for uninitialized SiteAccess #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Steveb-p merged 3 commits into from
Aug 4, 2026
Merged

IBX-12192: Skip SiteAccessStamp for uninitialized SiteAccess #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf44546
IBX-12192: Skip SiteAccessStamp for uninitialized SiteAccess
Steveb-p Aug 4, 2026
47dd96a
TEMPORARY: Added dependencies.json to test against ibexa/core#796
Steveb-p Aug 4, 2026
d0f5b22
Removed temporary dependencies.json
Steveb-p Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bundle/EventSubscriber/SendMessageSiteAccessSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Ibexa\Bundle\Messenger\EventSubscriber;

use Ibexa\Contracts\Messenger\Stamp\SiteAccessStamp;
use Ibexa\Core\MVC\Symfony\SiteAccess;
use Ibexa\Core\MVC\Symfony\SiteAccess\SiteAccessServiceInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Messenger\Event\SendMessageToTransportsEvent;
Expand All @@ -33,7 +34,7 @@ public static function getSubscribedEvents(): array
public function onSendMessageToTransport(SendMessageToTransportsEvent $event): void
{
$siteAccess = $this->siteAccessService->getCurrent();
if ($siteAccess === null) {
if ($siteAccess === null || $siteAccess->matchingType === SiteAccess::MATCHING_TYPE_UNINITIALIZED) {
return;
}

Expand Down
19 changes: 19 additions & 0 deletions tests/bundle/EventSubscriber/SendMessageSiteAccessSubscriberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,23 @@ public function testOnSendMessageToTransportDoesNothingWhenNoSiteAccess(): void
self::assertNull($updatedEnvelope->last(SiteAccessStamp::class));
self::assertSame($envelope, $updatedEnvelope);
}

public function testOnSendMessageToTransportDoesNothingWhenSiteAccessIsUninitialized(): void
{
$siteAccess = new SiteAccess('default', SiteAccess::MATCHING_TYPE_UNINITIALIZED);
$envelope = new Envelope(new \stdClass());
$event = new SendMessageToTransportsEvent($envelope);

$this->siteAccessService
->expects(self::once())
->method('getCurrent')
->willReturn($siteAccess);

$this->subscriber->onSendMessageToTransport($event);

$updatedEnvelope = $event->getEnvelope();

self::assertNull($updatedEnvelope->last(SiteAccessStamp::class));
self::assertSame($envelope, $updatedEnvelope);
}
}
Loading