Skip to content

IBX-11774: Changed location into locale in user settings group configuration #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barw4 wants to merge 1 commit into from
Closed

IBX-11774: Changed location into locale in user settings group configuration #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/bundle/Resources/config/services/user_settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ services:
#
Ibexa\User\UserSetting\Setting\Timezone:
tags:
- { name: ibexa.user.setting.value, identifier: timezone, group: location, priority: 50 }
- { name: ibexa.user.setting.value, identifier: timezone, group: locale, priority: 50 }
- { name: ibexa.user.setting.mapper.form, identifier: timezone }

Ibexa\User\UserSetting\Setting\SubitemsLimit:
Expand All @@ -90,7 +90,7 @@ services:
arguments:
$availableLocaleChoiceLoader: '@Ibexa\User\Form\ChoiceList\Loader\AvailableLocaleChoiceLoader'
tags:
- { name: ibexa.user.setting.value, identifier: language, group: location, priority: 10 }
- { name: ibexa.user.setting.value, identifier: language, group: locale, priority: 10 }
- { name: ibexa.user.setting.mapper.form, identifier: language }

Ibexa\User\UserSetting\DateTimeFormat\FullDateTimeFormatterFactory: ~
Expand All @@ -104,7 +104,7 @@ services:
arguments:
$formatter: '@ibexa.user.settings.full_datetime_format.formatter'
tags:
- { name: ibexa.user.setting.value, identifier: full_datetime_format, group: location, priority: 20 }
- { name: ibexa.user.setting.value, identifier: full_datetime_format, group: locale, priority: 20 }
- { name: ibexa.user.setting.mapper.form, identifier: full_datetime_format }

Ibexa\User\UserSetting\DateTimeFormat\ShortDateTimeFormatterFactory: ~
Expand All @@ -118,7 +118,7 @@ services:
arguments:
$formatter: '@ibexa.user.settings.short_datetime_format.formatter'
tags:
- { name: ibexa.user.setting.value, identifier: short_datetime_format, group: location, priority: 30 }
- { name: ibexa.user.setting.value, identifier: short_datetime_format, group: locale, priority: 30 }
- { name: ibexa.user.setting.mapper.form, identifier: short_datetime_format }

Ibexa\User\UserSetting\DateTimeFormat\FullDateFormatterFactory: ~
Expand Down Expand Up @@ -151,7 +151,7 @@ services:

Ibexa\User\UserSetting\Group\LocationGroup:
tags:
- { name: ibexa.user.setting.group, identifier: location, priority: 30 }
- { name: ibexa.user.setting.group, identifier: locale, priority: 30 }

Ibexa\User\UserSetting\Group\EditContentGroup:
tags:
Expand Down
4 changes: 2 additions & 2 deletions src/lib/UserSetting/Group/LocationGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
use Symfony\Contracts\Translation\TranslatorInterface;

/**
* The translation for the given group was changed to 'Locale' from 'Location'. However, for backwards compatibility
* we decided to keep the old configuration with corresponding classes and services as 'location'.
* The 'location' group was renamed to 'locale', including its identifier in the service configuration.
* However, for backwards compatibility the class name remains 'LocationGroup'.
*/
final class LocationGroup extends AbstractGroup
{
Expand Down
Loading