split win.lua into modules by phanen · Pull Request #2512 · ibhagwan/fzf-lua

phanen · 2026-01-13T12:00:51Z

refactor: split scrollbar/helpwin/backdrop/tsinjector from win.lua
chore: lint

phanen · 2026-01-18T03:39:52Z

Maybe we can generate screenshots on a fixed revision, to reduce screenshot rotten

ibhagwan · 2026-01-18T03:50:43Z

Maybe we can generate screenshots on a fixed revision, to reduce screenshot rotten

You mean when we add new files?

We can have a test folder with a few files and run all testing only inside the test folder - is this what you mean by fixed rev?

phanen · 2026-01-18T03:53:21Z

We can have a test folder with a few files and run all testing only inside the test folder - is this what you mean by fixed rev?

yes, that's also an option.

ibhagwan · 2026-01-18T04:00:11Z

We can have a test folder with a few files and run all testing only inside the test folder - is this what you mean by fixed rev?

yes, that's also an option.

I like the revision idea, reduces junk test files, slight issue is debugging the screenshots (if something is missing) is slightly more annoying.

phanen · 2026-01-18T04:45:18Z

now child run in ./deps/fzf-lua, test runner in ./.

Not sure why some grep/file screenshots changed

phanen · 2026-01-18T10:40:19Z

Confusing windows screenshot. so previous window use find, but now it use dir

phanen · 2026-01-19T08:41:02Z

Why this step is needed when we hide fzf win?

fzf-lua/lua/fzf-lua/win.lua

Lines 1049 to 1053 in 04a213b

    
           function FzfWin:detach_fzf_buf() 
        
             self._hidden_fzf_bufnr = self.fzf_bufnr 
        
             vim.bo[self._hidden_fzf_bufnr].bufhidden = "" 
        
             self:set_tmp_buffer(true) 
        
           end

Or why _hidden_fzf_bufnr is needed? I guess this is to avoid side effects of &hidden/&bufhidden options?

ibhagwan · 2026-02-22T17:18:09Z

Btw, do you know why in 740b07e the preview screenshots have one less character? is it due to the preview scrollbar?

phanen · 2026-02-23T01:36:10Z

is it due to the preview scrollbar?

not sure, I hope so..

ibhagwan · 2026-02-23T01:49:17Z

is it due to the preview scrollbar?

not sure, I hope so..

I don’t mind it, just want to understand if this is intentional and why it happens, the ci scroll bar didn’t change AFAIK so why would this happen

Test runner cwd unchanged, child init cwd is ./deps/fzf-lua Remember to wrap abspath when use some path in child

ibhagwan · 2026-02-23T01:50:17Z

485ee67, lucky guess, it seems that it was the scroll bar, maybe it’s enabled differently due to the refactor?

win.lua is a bit big now fix(tsinjector): detach after clear_cache

* remove "save/restore" hacks, use utils.win_set_config to remove style="minimal" * nvim_win_set_config title require without border only fail when <0.11

fix: correct win types fix(win): winrestcmd is only used for split

remove useless functions chore: setup autocmds together chore: consistent code style

keep consistant behavior with "reuse" win

the release order is a bit non-deterministic but should not be a big issue

neovim/neovim#37484

fix: vim.o.hidden=false

array part always emit, non-array part only emit on given events

chore: types

phanen · 2026-02-23T01:51:56Z

Yes, it's scrollbar. It shouldn't in that commit. I forgot to split this out when reorder the commit. But now it's fixed in b88d338.

ibhagwan · 2026-02-23T01:59:29Z

Yes, it's scrollbar. It shouldn't in that commit. I forgot to split this out when reorder the commit. But now it's fixed in b88d338.

Can i merge then

phanen · 2026-02-23T05:37:49Z

yes

phanen force-pushed the split-win branch 7 times, most recently from f34c822 to aeb9e7e Compare January 18, 2026 03:34

phanen force-pushed the split-win branch from aeb9e7e to c1555f5 Compare January 18, 2026 03:52

phanen force-pushed the split-win branch from c1555f5 to da0f2c8 Compare January 18, 2026 04:00

phanen force-pushed the split-win branch 2 times, most recently from e45b1d9 to d836dd7 Compare January 18, 2026 04:41

phanen force-pushed the split-win branch 12 times, most recently from 3281da7 to 04a213b Compare January 19, 2026 08:34

ci: pin screenshots revision

218114d

Test runner cwd unchanged, child init cwd is ./deps/fzf-lua Remember to wrap abspath when use some path in child

phanen added 19 commits February 23, 2026 09:50

refactor: split scrollbar/helpwin/backdrop/tsinjector from win.lua

fd565a8

win.lua is a bit big now fix(tsinjector): detach after clear_cache

refactor: win/border.lua

b88d338

refactor: split preview winhl

fb3face

refactor: simplify title config

9cf9c74

* remove "save/restore" hacks, use utils.win_set_config to remove style="minimal" * nvim_win_set_config title require without border only fail when <0.11

refactor: rename win.win_leave to win.close

fdb6061

fix: correct win types fix(win): winrestcmd is only used for split

chore: types

f41b15f

remove useless functions chore: setup autocmds together chore: consistent code style

fix(config): winopts.on_create keymap should override keymap.builtin

28115e8

keep consistant behavior with "reuse" win

refactor: release cb in on_closes

410f290

the release order is a bit non-deterministic but should not be a big issue

ci: better print errmsg

0f4b28e

chore: remove cursorline >0.11.6

fc29db3

neovim/neovim#37484

fix: correctly handle alt buf

365e07b

refactor: don't create another scratch buffer on win:hide()

9885602

fix: vim.o.hidden=false

refactor: treesitter_attach handle detach when reuse win

be3f06a

chore: vim.F.if_nil

b7e3107

fix: global picker cannot toggle-preview on split layout

f8d5a2e

fix: SIGWINCH after window shown to fix redraw on split=enew

4f1fddc

fix: simplify sigwinch code

25b328c

array part always emit, non-array part only emit on given events

refactor(rpc): pass more ctx ($FZF_* envs)

99e6651

chore: types

fix: :FzfLua global previewer didn't update when hide->unhide

1854e65

phanen force-pushed the split-win branch from 485ee67 to 1854e65 Compare February 23, 2026 01:50

ibhagwan merged commit 5e5cbc9 into ibhagwan:main Feb 23, 2026
8 checks passed

pranavavva mentioned this pull request Feb 23, 2026

fix bug when close_buf called with nil fzf_bufnr #2579

Merged

Conversation

phanen commented Jan 13, 2026

Uh oh!

phanen commented Jan 18, 2026

Uh oh!

ibhagwan commented Jan 18, 2026

Uh oh!

phanen commented Jan 18, 2026

Uh oh!

ibhagwan commented Jan 18, 2026

Uh oh!

phanen commented Jan 18, 2026

Uh oh!

phanen commented Jan 18, 2026

Uh oh!

phanen commented Jan 19, 2026

Uh oh!

ibhagwan commented Feb 22, 2026

Uh oh!

phanen commented Feb 23, 2026

Uh oh!

ibhagwan commented Feb 23, 2026

Uh oh!

ibhagwan commented Feb 23, 2026

Uh oh!

phanen commented Feb 23, 2026

Uh oh!

ibhagwan commented Feb 23, 2026

Uh oh!

phanen commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants