Merged
Conversation
Replaced endsWith with equals to avoid unwanted matches e.g. stop_areas.txt being used instead of areas.txt
… generic unit tests which uses
…ator with OS derived reference Test should now work on Linux
…atch what will be provided):
…entities will be returned
… the route network table The route id is unique to the route table has well. This prevents duplicate key failures
… export to separate files
… test to include stop area ids
…cations to check subdirectories
Merge stop areas into stops
miles-grant-ibigroup
approved these changes
Apr 15, 2026
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
This looks great! Because of the scope of these changes I couldn't review as carefully as I could for a smaller PR, but everything seems to work well and the changes look clean
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
First round of comments just from reading some of the files. More to come.
binh-dam-ibigroup
requested changes
Apr 20, 2026
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Just a few refactor requests for now, and I still need to run the code with the other stuff,
mainly split CsvReaderUtil.getCsvReaderFromMergedFiles, inling a few return, and cleaning up dead code. The other suggestions and comment additions would be nice to have.
binh-dam-ibigroup
requested changes
Apr 22, 2026
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
One more small change in the tests, then I will approve. The other changes seem fine and appear to work with datatools-server.
7 tasks
binh-dam-ibigroup
approved these changes
Apr 23, 2026
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Thank you for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Update to include fares v2 based on design:
https://docs.google.com/document/d/1EBMoxfXscPhFWyrn4fyGR6foQ7JGBWvMWeodrvo7DPw/edit