Skip to content

[minor] Add redis-cli installation to cli-base image#34

Merged
whitfiea merged 2 commits into
stablefrom
mascore-13109-branch-lock
Apr 17, 2026
Merged

[minor] Add redis-cli installation to cli-base image#34
whitfiea merged 2 commits into
stablefrom
mascore-13109-branch-lock

Conversation

@Hardik-Prajapati-10
Copy link
Copy Markdown
Contributor

Issue

https://jsw.ibm.com/browse/MASCORE-13109

Description

This PR adds redis-cli installation to the cli-base image, moving it from the downstream cli repository where it was previously installed. This change improves the architecture by:

Why:

  • Third-party CLI tools should be installed in the base image for consistency
  • Enables reusability across all images derived from cli-base
  • Centralizes management of third-party dependencies
  • Improves build efficiency by avoiding redundant installations

What Changed:

  1. Created install-redis-cli.sh script with multi-platform support:

    • Supports dnf, microdnf, yum, apt-get, and apk package managers
    • Handles EPEL repository setup for RHEL/UBI systems
    • Manages Redis module streams for RHEL 9
    • Includes verification step to ensure successful installation
  2. Updated Dockerfile to include redis-cli installation step

  3. Updated README.md to document redis-cli availability across all architectures (amd64, s390x, arm64)

Impact:

  • redis-cli will be available in all images built from cli-base
  • Downstream cli repository will automatically inherit redis-cli without additional installation steps
  • No breaking changes - redis-cli functionality remains the same

Test Results

Testing will be performed through:

  1. GitHub Actions build pipeline will verify the image builds successfully
  2. Post-build verification: redis-cli --version command
  3. Integration testing in downstream cli repository to ensure distributed locking functionality works correctly

Backporting

Backporting may be required depending on which versions of MAS require redis-cli functionality. Please advise if backports to 9.0, 8.11, or 8.10 are needed.

Related Pull Requests

  • cli repository: A follow-up PR may be needed to remove the now-redundant redis-cli installation script once this change is merged and the new cli-base image is available

⚠️ Notes for Reviewers

  • Ensure you have understood the guidelines before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.
  • Verify that the install script handles all supported package managers correctly
  • Confirm that the installation step is placed appropriately in the Dockerfile
  • Check that the README.md accurately reflects the new capability

- Added install-redis-cli.sh script with support for multiple package managers
- Updated Dockerfile to include redis-cli installation step
- Supports dnf, microdnf, yum, apt-get, and apk package managers
- Includes verification step to ensure successful installation
@whitfiea whitfiea merged commit c982941 into stable Apr 17, 2026
5 checks passed
@whitfiea whitfiea deleted the mascore-13109-branch-lock branch April 17, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants