[patch] add DB2 license file support to FVT update task#2289
Draft
terc1997 wants to merge 5 commits into
Draft
Conversation
| if [[ -n "DB2_LICENSE" ]]; then | ||
| mas update --catalog $MAS_CATALOG_VERSION_UPDATE $CLI_UPDATE_EXTRA_FLAGS --no-confirm | ||
| else | ||
| mas update --catalog $MAS_CATALOG_VERSION_UPDATE $CLI_UPDATE_EXTRA_FLAGS --db2-license-file $DB2_LICENSE --no-confirm |
Contributor
There was a problem hiding this comment.
Do we need to add --db2-license-file $DB2_LICENSE here explicitly?
Can't we pass it through CLI_UPDATE_EXTRA_FLAGS var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change was made to include the new required Db2 License file to FVT day 2
Related Issues
Provide a list of Jira issues related to this change, if this change is part of an epic include a link to the epic as well.
If there are no Jira issues related to this change, why are you working on it?
Related PRs
How Has This Been Tested?
Please describe how the change has been tested, beyond the molecule tests ran in Travis build.
If you have not performed any additional testing please explain why this change does not need further testing.