inventory_mac: Skip IP assignment if already configured#245
Open
abhilashraju wants to merge 1 commit into
Open
inventory_mac: Skip IP assignment if already configured#245abhilashraju wants to merge 1 commit into
abhilashraju wants to merge 1 commit into
Conversation
Add check to prevent unnecessary IP deletion and reassignment when the target IP address and prefix length are already configured on the network interface. This optimization avoids disrupting existing network connections and reduces unnecessary operations. Changes: - Check if IP address and prefix are already assigned before deletion - Skip deleteAll() and ip() calls if IP already exists - Add informative logging when skipping assignment - Maintain ipAssigned flag for both new and existing IP cases This prevents network disruption when the same IP configuration is applied multiple times to the same interface. Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check to prevent unnecessary IP deletion and reassignment when the target IP address and prefix length are already configured on the network interface. This optimization avoids disrupting existing network connections and reduces unnecessary operations.
Changes:
This prevents network disruption when the same IP configuration is applied multiple times to the same interface.