Use surrounding text for the "reconvert" feature instead of the clipb…#43
Closed
mike-fabian wants to merge 1 commit intoibus:mainfrom
Closed
Use surrounding text for the "reconvert" feature instead of the clipb…#43mike-fabian wants to merge 1 commit intoibus:mainfrom
mike-fabian wants to merge 1 commit intoibus:mainfrom
Conversation
…oard - Avoids using Gtk or Gdk - Deletes the selection immediately when reconverting starts instead of replacing the selection when the reconversion is finished (which is the way it works when using the clipboard)
Member
|
As I noted, I won't use the surrounding text feature for the reconvert. |
Author
|
Why not? I think it works better than the clipboard. ibus-mozc is using surrounding text for this as well. |
Member
|
I don't pay attention to the unstable feature and I also think your patch is not good and taking the code review would be a cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oard