Skip to content

consistent codecov.yml with ibutsu-server#10

Merged
mshriver merged 1 commit intomainfrom
codecov-fixes
Nov 7, 2025
Merged

consistent codecov.yml with ibutsu-server#10
mshriver merged 1 commit intomainfrom
codecov-fixes

Conversation

@mshriver
Copy link
Contributor

@mshriver mshriver commented Nov 7, 2025

Summary by Sourcery

Align codecov configuration with ibutsu-server by normalizing booleans, enforcing explicit coverage targets, and updating comment behavior

Enhancements:

  • Normalize boolean values for require_ci_to_pass and wait_for_ci to true/false
  • Set explicit 85% coverage targets for project and patch and treat CI failures as errors
  • Introduce an 'unittests' flag with carryforward for src/ paths
  • Update comment layout order and disable require_changes

Copilot AI review requested due to automatic review settings November 7, 2025 12:58
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR standardizes the codecov.yml configuration by normalizing boolean values, enforcing explicit coverage targets with failure behavior, adding test flags, and refining the comment layout to match ibutsu-server conventions.

Flow diagram for Codecov coverage status evaluation

flowchart TD
  Start["Start CI"] --> RunTests["Run Tests"]
  RunTests --> UploadCoverage["Upload Coverage to Codecov"]
  UploadCoverage --> EvaluateProject["Evaluate Project Coverage (target: 85%, threshold: 1%)"]
  UploadCoverage --> EvaluatePatch["Evaluate Patch Coverage (target: 85%, threshold: 1%)"]
  EvaluateProject -->|if_ci_failed: error| FailPR["Fail PR"]
  EvaluatePatch -->|if_ci_failed: error| FailPR
  EvaluateProject -->|pass| Success["Success"]
  EvaluatePatch -->|pass| Success
Loading

File-Level Changes

Change Details Files
Normalize YAML boolean fields
  • Changed require_ci_to_pass from yes to true
  • Updated notify.wait_for_ci from yes to true
  • Switched comment.require_changes from no to false
codecov.yml
Enforce explicit coverage targets with CI failure handling
  • Set project and patch default targets to 85% instead of auto
  • Removed base auto behavior and added if_ci_failed:error for both project and patch
codecov.yml
Add unittest flags configuration
  • Introduced flags.unittests section
  • Scoped paths to src/ and enabled carryforward
codecov.yml
Adjust comment layout
  • Changed layout order from reach,diff,flags,tree to header,diff,flags,files,footer
codecov.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Codecov configuration file to modernize settings and enforce stricter coverage requirements. The changes align with current best practices and establish clearer coverage targets.

  • Standardized boolean values from yes/no to true/false
  • Increased coverage targets from auto to fixed 85% threshold for both project and patch
  • Added flags configuration for unit tests with carryforward support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mshriver mshriver merged commit f46dff3 into main Nov 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants