Skip to content

provenance is granted but 404 for package#9

Merged
mshriver merged 2 commits intomainfrom
npm-trusted
Nov 6, 2025
Merged

provenance is granted but 404 for package#9
mshriver merged 2 commits intomainfrom
npm-trusted

Conversation

@mshriver
Copy link
Contributor

@mshriver mshriver commented Nov 6, 2025

trying an NPM token with write access

Summary by Sourcery

Provide NPM auth token in publish workflow and correct repository URL format

Bug Fixes:

  • Fix npm publish 404 by supplying NODE_AUTH_TOKEN from secrets

Enhancements:

  • Remove custom registry-url step from workflow
  • Update package.json repository URL to use git+https format

Copilot AI review requested due to automatic review settings November 6, 2025 13:18
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR modifies the GitHub Actions workflow to authenticate npm publishes using a token and corrects the package.json repository URL format.

Class diagram for updated package.json repository field

classDiagram
  class PackageJson {
    +name: string
    +version: string
    +repository: Repository
    +keywords: string[]
    ...
  }
  class Repository {
    +type: string
    +url: string
    +url: "git+https://github.com/ibutsu/ibutsu-client-javascript.git"
  }
  PackageJson --> Repository
Loading

File-Level Changes

Change Details Files
Use NPM token for authenticated publishes in CI
  • Removed hardcoded registry-url parameter
  • Added NODE_AUTH_TOKEN environment variable to publish step
.github/workflows/npm-publish.yml
Correct repository URL format for NPM
  • Prefixed repository URL with git+
  • Ensured URL matches NPM expectations
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

trying an NPM token with write access
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the npm publishing workflow configuration and package metadata. The changes prepare the package for proper npm publishing by adding authentication configuration and standardizing the repository URL format.

  • Adds npm authentication token to the publish workflow
  • Updates repository URL to include the git+ protocol prefix
  • Removes the registry-url configuration from the workflow setup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Adds git+ prefix to repository URL for npm standard format
.github/workflows/npm-publish.yml Adds NPM_TOKEN authentication for publishing, removes registry-url from setup-node

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mshriver mshriver merged commit e060fa1 into main Nov 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants