feat: image handle from path with a user provided version#3310
Open
hojjatabdollahi wants to merge 1 commit into
Open
feat: image handle from path with a user provided version#3310hojjatabdollahi wants to merge 1 commit into
hojjatabdollahi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow the user to provide a version alongside the file path. The version could be based on file metadata, size, modification time, inode, file hash... The onus is on the user to provide what makes the image unique. This keeps the construction of the handle cheap, but the handle contains info that the user can use to know if the cached image is outdated.
Alternatively, we can add this to
Handle::from_pathand force everybody to provide something, letting them know that if a file changes in-place the handle won't change and the old cached image will be used.To fix issues like #2941.