Add COPY_SRC to surface usages if supported#3341
Open
maxbergmark wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mimics the exact changes of #3316, adding
COPY_SRCto the surface usage if it is supported. Per the discussion in the other PR, this doesn't work for WASM due to an oversight inwgpu. Possible workarounds to enable support for WASM:Force
COPY_SRCwhen targeting WebGPUFrom my testing, this is supported on most browsers. The only exception so far has been Safari, but that's not related to the
COPY_SRCflag.Add new feature flag to
icedto forceCOPY_SRCThis would be a more prudent solution, making the usage explicit for WASM targets. However, adding a new feature flag for this single use case might not be the cleanest solution.
Completely skip WASM support
As is, this PR will not enable
COPY_SRCfor WASM targets. This would unfortunately not enable WASM support for crates like iced_glass. However, if the solutions above aren't acceptable this could be an alternative.I would love to get some input regarding the choices above, or any other potential problems or solutions that I haven't considered.