Open
Conversation
There was a problem hiding this comment.
Pull request overview
Renames the Slice/Ice code generation test projects and corresponding namespaces/modules as preliminary work for #4284 (separating Ice vs Slice codec and IceRpc integrations), without changing test logic.
Changes:
- Renamed test projects from
*.IceGen.Tests/*.SlicecGen.Teststo*.CodeGen.Testsand updated solution wiring. - Updated C# namespaces and Slice/Ice module names/type-id expectations to match the new project names.
- Updated internal visibility and build/test tooling references to the renamed assemblies.
Reviewed changes
Copilot reviewed 99 out of 107 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/slicec-cs/src/cs_compile.rs | Updates slicec-cs test harness reference path to renamed ZeroC Slice CodeGen tests directory. |
| tests/ZeroC.Slice.CodeGen.Tests/ZeroC.Slice.CodeGen.Tests.csproj | New/renamed test project definition for ZeroC Slice code generation tests. |
| tests/ZeroC.Slice.CodeGen.Tests/WellKnownTypesTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/WellKnownTypes.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/TypeNameQualificationTests2.slice | Module rename to ZeroC::Slice::CodeGen::Tests::Inner. |
| tests/ZeroC.Slice.CodeGen.Tests/TypeNameQualificationTests1.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/TypeNameQualificationTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/TypeIdAttributeTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests::TypeIdAttributeTestNamespace. |
| tests/ZeroC.Slice.CodeGen.Tests/TypeIdAttributeTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests.TypeIdAttributeTestNamespace. |
| tests/ZeroC.Slice.CodeGen.Tests/TaggedTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/TaggedTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/StructTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/StructTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/ResultTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/ResultTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/IdentifierAttributeTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/IdentifierAttributeTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests.Identifiers. |
| tests/ZeroC.Slice.CodeGen.Tests/EnumWithFieldsTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/EnumWithFieldsTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/EnumTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/EnumTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/DictionaryEncodingTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/DictionaryDecodingTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/CustomTypeTests.slice | Module rename to ZeroC::Slice::CodeGen::Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/CustomTypeTests.cs | Namespace rename to ZeroC.Slice.CodeGen.Tests. |
| tests/ZeroC.Slice.CodeGen.Tests/CsNamespaceAttributeTests.slice | Updates cs::namespace attribute string to new CodeGen namespace. |
| tests/ZeroC.Slice.CodeGen.Tests/CsNamespaceAttributeTests.cs | Namespace rename + assertion updates for new mapped namespace string. |
| tests/ZeroC.Ice.CodeGen.Tests/ZeroC.Ice.CodeGen.Tests.csproj | Updates referenced-assemblies project references to renamed folder. |
| tests/ZeroC.Ice.CodeGen.Tests/TypeIdAttributeTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests::TypeIdAttributeTestNamespace. |
| tests/ZeroC.Ice.CodeGen.Tests/TypeIdAttributeTests.cs | Namespace rename + type-id string updates to new module path. |
| tests/ZeroC.Ice.CodeGen.Tests/TaggedTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/TaggedTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/SlicingTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/SlicingTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/SequenceDecodingTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/SequenceDecodingTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/IdentifierAttributeTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/IdentifierAttributeTests.cs | Namespace rename + type-id string update for renamed module. |
| tests/ZeroC.Ice.CodeGen.Tests/ExceptionTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/ExceptionTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/EnumTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/EnumTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/ClassTests.ice | Module rename to ZeroC::Ice::CodeGen::Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/ClassTests.cs | Namespace rename to ZeroC.Ice.CodeGen.Tests. |
| tests/ZeroC.Ice.CodeGen.Tests/ActivatorTests.cs | Updates referenced-assemblies namespace import + test namespace rename. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/DPrime/DPrime.ice | Module rename to Ice::CodeGen::Tests::ReferencedAssemblies. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/DPrime/DPrime.csproj | New referenced-assembly project definition under renamed folder. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/D/D.ice | Module rename to Ice::CodeGen::Tests::ReferencedAssemblies. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/D/D.csproj | New referenced-assembly project definition under renamed folder. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/C/C.ice | Module rename to Ice::CodeGen::Tests::ReferencedAssemblies. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/C/C.csproj | New referenced-assembly project definition under renamed folder. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/B/B.ice | Module rename to Ice::CodeGen::Tests::ReferencedAssemblies. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/B/B.csproj | New referenced-assembly project definition under renamed folder. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/A/A.ice | Module rename to Ice::CodeGen::Tests::ReferencedAssemblies. |
| tests/ZeroC.Ice.CodeGen.Tests.ReferencedAssemblies/A/A.csproj | New referenced-assembly project definition under renamed folder. |
| tests/IceRpc.Slice.SlicecGen.Tests/OperationDerivedTests.slice | Removed from old SlicecGen test project path. |
| tests/IceRpc.Slice.SlicecGen.Tests/NamespaceAttributeTests2.slice | Removed from old SlicecGen test project path. |
| tests/IceRpc.Slice.CodeGen.Tests/TypeNameQualificationTests2.slice | Module rename to IceRpc::Slice::CodeGen::Tests::Inner. |
| tests/IceRpc.Slice.CodeGen.Tests/TypeNameQualificationTests1.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/TypeNameQualificationTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/StructTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/StructTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/StreamTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/ServiceTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/ServiceTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/ServiceProviderExtensionsTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/SequenceMappingTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/SequenceMappingTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/ProxyTests.slice | Module rename + cs::type strings updated to CodeGen namespace. |
| tests/IceRpc.Slice.CodeGen.Tests/ProxyTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/Pingable.slice | Module rename + cs::type updated to CodeGen namespace. |
| tests/IceRpc.Slice.CodeGen.Tests/OperationTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/OperationTests.cs | Namespace rename + updated derived-tests using. |
| tests/IceRpc.Slice.CodeGen.Tests/OperationEncodingTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/OperationEncodingTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/OperationDerivedTests.slice | Added under new CodeGen test project path with updated module/type references. |
| tests/IceRpc.Slice.CodeGen.Tests/NamespaceAttributeTests2.slice | Added under new CodeGen test project path with updated cs::namespace. |
| tests/IceRpc.Slice.CodeGen.Tests/NamespaceAttributeTests1.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/NamespaceAttributeTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/InvokeOperationAsyncTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/InvalidProxy.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/InterfaceTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/InterfaceTests.cs | Namespace rename + updated expected type-id/service-path strings. |
| tests/IceRpc.Slice.CodeGen.Tests/IdentifierAttributeTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/IdentifierAttributeTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests.Identifiers. |
| tests/IceRpc.Slice.CodeGen.Tests/IceRpc.Slice.CodeGen.Tests.csproj | New/renamed test project definition for IceRpc Slice code generation tests. |
| tests/IceRpc.Slice.CodeGen.Tests/EnumTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/EnumTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/DocumentationTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/DictionaryMappingTests.slice | Module rename to IceRpc::Slice::CodeGen::Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/DictionaryMappingTests.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/CustomSequence.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Slice.CodeGen.Tests/CustomDictionary.cs | Namespace rename to IceRpc.Slice.CodeGen.Tests. |
| tests/IceRpc.Ice.CodeGen.Tests/StructTests.ice | Module rename to IceRpc::Ice::CodeGen::Tests. |
| tests/IceRpc.Ice.CodeGen.Tests/StructTests.cs | Namespace rename to IceRpc.Ice.CodeGen.Tests (+ added using IceRpc.Slice;). |
| tests/IceRpc.Ice.CodeGen.Tests/ProxyTests.cs | Namespace rename to IceRpc.Ice.CodeGen.Tests (+ added using IceRpc.Slice;). |
| tests/IceRpc.Ice.CodeGen.Tests/InvalidProxy.cs | Namespace rename + added using IceRpc.Slice; for IProxy usage. |
| tests/IceRpc.Ice.CodeGen.Tests/IceRpc.Ice.CodeGen.Tests.csproj | New/renamed test project definition for IceRpc Ice code generation tests. |
| tests/IceRpc.Ice.CodeGen.Tests/ExceptionTests.ice | Module rename to IceRpc::Ice::CodeGen::Tests. |
| tests/IceRpc.Ice.CodeGen.Tests/ExceptionTests.cs | Namespace rename to IceRpc.Ice.CodeGen.Tests (+ added using IceRpc.Slice;). |
| tests/IceRpc.Ice.CodeGen.Tests/DocumentationTests.ice | Module rename to IceRpc::Ice::CodeGen::Tests. |
| tests/IceRpc.Ice.CodeGen.Tests/ClassTests.ice | Module rename to IceRpc::Ice::CodeGen::Tests. |
| tests/IceRpc.Ice.CodeGen.Tests/ClassTests.cs | Namespace rename to IceRpc.Ice.CodeGen.Tests. |
| src/ZeroC.Slice.Codec/AssemblyInfo.cs | Updates InternalsVisibleTo to renamed Ice CodeGen tests assembly. |
| src/IceRpc/AssemblyInfo.cs | Updates InternalsVisibleTo to renamed Slice CodeGen tests assembly. |
| IceRpc.slnx | Updates solution project list to renamed CodeGen test projects and referenced-assemblies projects. |
| .vscode/settings.json | Updates VS Code test path configuration to renamed Slice CodeGen test directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pepone
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preliminary work for #4284.
The tests were renamed without any change other than namespace/module fixes.