Skip to content

Move InvocationMode and TcpServerAddressBody to IceRpc::Ice::Internal#42

Merged
bernardnormier merged 1 commit intoicerpc:mainfrom
bernardnormier:move-ice-internal
Mar 10, 2026
Merged

Move InvocationMode and TcpServerAddressBody to IceRpc::Ice::Internal#42
bernardnormier merged 1 commit intoicerpc:mainfrom
bernardnormier:move-ice-internal

Conversation

@bernardnormier
Copy link
Copy Markdown
Member

This PR moves these .ice files to IceRpc/Ice/Internal and removes IceRpc/Slice.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves internal Ice-related Slice definitions into the IceRpc::Ice::Internal module/namespace, aligning file placement with the IceRpc/Ice/Internal directory and removing the prior IceRpc::Slice::Internal module naming.

Changes:

  • Updated TcpServerAddressBody and InvocationMode module declarations from IceRpc::Slice::Internal to IceRpc::Ice::Internal.
  • Tweaked doc comments to reflect “Ice proxy” wording.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
IceRpc/Ice/Internal/TcpServerAddressBody.ice Renames module to IceRpc::Ice::Internal and updates wording in the struct doc comment.
IceRpc/Ice/Internal/InvocationMode.ice Renames module to IceRpc::Ice::Internal and updates wording in the enum doc comment.
Comments suppressed due to low confidence (1)

IceRpc/Ice/Internal/TcpServerAddressBody.ice:5

  • Doc comment uses lowercase protocol acronyms ("tcp"/"ssl"); consider capitalizing to "TCP"/"SSL" for consistency and readability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernardnormier bernardnormier merged commit b2360da into icerpc:main Mar 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants