Move InvocationMode and TcpServerAddressBody to IceRpc::Ice::Internal#42
Merged
bernardnormier merged 1 commit intoicerpc:mainfrom Mar 10, 2026
Merged
Conversation
pepone
approved these changes
Mar 10, 2026
There was a problem hiding this comment.
Pull request overview
Moves internal Ice-related Slice definitions into the IceRpc::Ice::Internal module/namespace, aligning file placement with the IceRpc/Ice/Internal directory and removing the prior IceRpc::Slice::Internal module naming.
Changes:
- Updated
TcpServerAddressBodyandInvocationModemodule declarations fromIceRpc::Slice::InternaltoIceRpc::Ice::Internal. - Tweaked doc comments to reflect “Ice proxy” wording.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IceRpc/Ice/Internal/TcpServerAddressBody.ice | Renames module to IceRpc::Ice::Internal and updates wording in the struct doc comment. |
| IceRpc/Ice/Internal/InvocationMode.ice | Renames module to IceRpc::Ice::Internal and updates wording in the enum doc comment. |
Comments suppressed due to low confidence (1)
IceRpc/Ice/Internal/TcpServerAddressBody.ice:5
- Doc comment uses lowercase protocol acronyms ("tcp"/"ssl"); consider capitalizing to "TCP"/"SSL" for consistency and readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
externl
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves these .ice files to IceRpc/Ice/Internal and removes IceRpc/Slice.