Add onDismiss handler to handle Escape button click#796
Open
DavidTanner wants to merge 1 commit intoicflorescu:nextfrom
Open
Add onDismiss handler to handle Escape button click#796DavidTanner wants to merge 1 commit intoicflorescu:nextfrom
DavidTanner wants to merge 1 commit intoicflorescu:nextfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the onDismiss parameter on the Mantine Popover used within DataTableHeaderCellFilter in mantine-datatable.
Currently, the DataTableHeaderCellFilter component creates an internal Popover but does not pass the close handler to the Popover component. As a result, consumers of mantine-datatable cannot react when the filter popover is dismissed from an escape event.
This PR forwards the close callback to the underlying Popover onDismiss handler, allowing the filter to respond to popover dismissal events.