Kiselev Semyon M24-IVT-2

.github/workflows/c-cpp.yml

@@ -0,0 +1,32 @@
+name: C/C++ CI
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: checkout
+      uses: actions/checkout@v4
+
+
+    - name: get gcc
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y build-essential gcc
+
+    - name: tests
+      run: |
+        gcc -fsanitize=address 05_hw/tests.c -o tests.exe
+        ./tests.exe
+
+
+
+
+

05_hw/benchmarks.c

@@ -0,0 +1,73 @@
+#include <stdio.h>
+#include <stdlib.h>
+#include <time.h>
+
+#include "stack.h"
+#include "stack.c"
+
+void benchmark_push(Stack* stack, int ITEMS){
+    //Start the clock
+    clock_t start = clock();
+
+    //Push X elements
+    for (int i = 0; i < ITEMS; i++){
+        push(stack, i);
+    }
+
+    //Stop the clock
+    clock_t end = clock();
+
+    //Calculate the time
+    float benchmark_time = (float)(end - start) / CLOCKS_PER_SEC;
+
+    printf("Time taken to complete push benchmark (%d elements): %.5f seconds\n", ITEMS, benchmark_time);
+
+}
+
+void benchmark_pop(Stack* stack, int ITEMS){
+
+    //Start the clock
+    clock_t start = clock();
+
+
+    //Pop X elements
+    for (int i = 0; i < ITEMS; i++){
+        pop(stack);
+    }
+
+    //Stop the clock
+    clock_t end = clock();
+
+    //Calculate the time
+    float benchmark_time = (float)(end - start) / CLOCKS_PER_SEC;
+
+    printf("Time taken to complete pop benchmark (%d elements): %.5f seconds\n", ITEMS, benchmark_time);
+
+}
+
+int main(){
+
+    //Test with different num of elements
+    int NUMBER_TESTS[] = {1000, 10000, 1000000};
+
+
+    //Do 3 benchmarks
+    for (int i = 0; i < 3; i++){
+        //Stack init
+        Stack stack;
+        initStack(&stack);
+
+        benchmark_push(&stack, NUMBER_TESTS[i]);
+
+        for (int i = 0; i < NUMBER_TESTS[i]; i++){
+            push(&stack, i);
+        }
+
+        benchmark_pop(&stack, NUMBER_TESTS[i]);
+
+        destroyStack(&stack);
+    }
+
+    return 0;  
+
+}

05_hw/main.c

@@ -1,6 +1,7 @@
 #include "stack.h"
 
 #include <stdio.h>
+#include "stack.c"
 
 int main() {
     Stack stack;
@@ -18,14 +19,14 @@ int main() {
     printf("After popping an element:\n");
     traverseStack(&stack);
 
-    Node* searchResult = searchByValue(&stack, 20);
+    const Node* searchResult = searchByValue(&stack, 20);
     if (searchResult != NULL) {
         printf("Element with value 20 found.\n");
     } else {
         printf("Element with value 20 not found.\n");
     }
 
-    Node* topElement = getTop(&stack);
+    const Node* topElement = getTop(&stack);
     if (topElement != NULL) {
         printf("Top element: %d\n", topElement->data);
     }

05_hw/report.txt

@@ -0,0 +1,17 @@
+Running: cppcheck --enable=all --template={"file":"{file}","line":{line},"column":{column},"severity":"{severity}","message":"{message}","id":"{id}"}, c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\main.c
+Checking c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\main.c ...
+
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.h","line":3,"column":0,"severity":"information","message":"Include file: <stdbool.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.","id":"missingIncludeSystem"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\main.c","line":3,"column":0,"severity":"information","message":"Include file: <stdio.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.","id":"missingIncludeSystem"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":1,"column":0,"severity":"information","message":"Include file: <stdio.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.","id":"missingIncludeSystem"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":2,"column":0,"severity":"information","message":"Include file: <stdlib.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.","id":"missingIncludeSystem"},
+
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\main.c","line":22,"column":11,"severity":"style","message":"Variable 'searchResult' can be declared as pointer to const","id":"constVariablePointer"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\main.c","line":29,"column":11,"severity":"style","message":"Variable 'topElement' can be declared as pointer to const","id":"constVariablePointer"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":71,"column":21,"severity":"style","message":"Parameter 'stack' can be declared as pointer to const","id":"constParameterPointer"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":85,"column":21,"severity":"style","message":"Parameter 'stack' can be declared as pointer to const","id":"constParameterPointer"},
+
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":21,"column":6,"severity":"style","message":"The function 'destroyStack' is never used.","id":"unusedFunction"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":58,"column":7,"severity":"style","message":"The function 'searchByIndex' is never used.","id":"unusedFunction"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":85,"column":6,"severity":"style","message":"The function 'isEmpty' is never used.","id":"unusedFunction"},
+{"file":"c:\Users\User\Desktop\works\lecture-testing-task-main\05_hw\stack.c","line":6,"column":7,"severity":"style","message":"The function 'createNode' should have static linkage since it is not used outside of its translation unit.","id":"staticFunction"},

05_hw/stack.c

@@ -5,6 +5,10 @@
 
 Node* createNode(int data) {
     Node* newNode = (Node*)malloc(sizeof(Node));
+	if (newNode == NULL){
+		printf("malloc failure");
+		exit(EXIT_FAILURE);
+	}
     newNode->data = data;
     newNode->next = NULL;
     return newNode;
@@ -17,10 +21,11 @@ void initStack(Stack* stack) {
 void destroyStack(Stack* stack) {
     Node* current = stack->top;
     while (current != NULL) {
-        Node *tmp = current;
+        Node* tmp = current;
         current = current->next;
 	    free(tmp);
     }
+	stack->top = NULL;
 }
 
 void push(Stack* stack, int data) {
@@ -30,8 +35,13 @@ void push(Stack* stack, int data) {
 }
 
 void pop(Stack* stack) {
+	if (stack->top == NULL){
+		printf("Attempting to pop an empty stack\n");
+		return;
+	}
     Node* temp = stack->top;
     stack->top = stack->top->next;
+	free(temp);
 }
 
 Node* searchByValue(Stack* stack, int value) {
@@ -40,6 +50,7 @@ Node* searchByValue(Stack* stack, int value) {
         if (current->data == value) {
             return current;
         }
+		current = current->next;
     }
     return NULL;
 }
@@ -57,7 +68,7 @@ Node* searchByIndex(Stack* stack, int index) {
     return NULL;
 }
 
-Node* getTop(Stack* stack) {
+Node* getTop(Stack* const stack) {
     return stack->top;
 }
 
@@ -71,8 +82,7 @@ void traverseStack(Stack* stack) {
     printf("\n");
 }
 
-bool isEmpty(Stack* stack) {
-    free(stack->top);
+bool isEmpty(Stack* const stack) {
     return stack->top == NULL;
 }
 

05_hw/stack.h

@@ -19,7 +19,7 @@ Node* createNode(int data);
 
 void initStack(Stack* stack);
 
-void destroyStack(Stack *stack);
+void destroyStack(Stack* stack);
 
 void push(Stack* stack, int data);