Skip to content

Fix a small memory leak when using OpenSSL's BIGNUMs. [Theo Buehler] #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
icing wants to merge 1 commit into from
Closed

Fix a small memory leak when using OpenSSL's BIGNUMs. [Theo Buehler] #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Fix a small memory leak when using OpenSSL's BIGNUMs. [Theo Buehler]

v2.6.5
----------------------------------------------------------------------------------------------------
* Hardening: when build with OpenSSL older than 1.0.2 or old libressl versions,
Expand Down
4 changes: 2 additions & 2 deletions src/md_crypt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,7 +1244,7 @@ const char *md_cert_get_serial_number(const md_cert_t *cert, apr_pool_t *p)
serial = BN_bn2hex(bn);
s = apr_pstrdup(p, serial);
OPENSSL_free((void*)serial);
OPENSSL_free((void*)bn);
BN_free(bn);
}
return s;
}
Expand Down Expand Up @@ -2254,7 +2254,7 @@ apr_status_t md_cert_get_ari_cert_id(const char **pari_cert_id,
memset(&ser_buf, 0, sizeof(ser_buf));
bn = ASN1_INTEGER_to_BN(serial, NULL);
sder_len = BN_bn2bin(bn, sbuf);
OPENSSL_free((void*)bn);
BN_free(bn);
if (sder_len < 1)
return APR_EINVAL;
ser_buf.len = (apr_size_t)sder_len;
Expand Down
2 changes: 1 addition & 1 deletion src/md_ocsp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ static const char *certid_summary(const OCSP_CERTID *certid, apr_pool_t *p)
bn = ASN1_INTEGER_to_BN(aserial, NULL);
s = BN_bn2hex(bn);
serial = apr_pstrdup(p, s);
OPENSSL_free((void*)bn);
BN_free(bn);
OPENSSL_free((void*)s);
}
return apr_psprintf(p, "certid[der=%s, issuer=%s, key=%s, serial=%s]",
Expand Down
Loading